Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace setup.py and requirements.txt with poetry or rye #69

Open
shrik450 opened this issue Apr 3, 2024 · 0 comments
Open

Replace setup.py and requirements.txt with poetry or rye #69

shrik450 opened this issue Apr 3, 2024 · 0 comments

Comments

@shrik450
Copy link
Collaborator

shrik450 commented Apr 3, 2024

Since we're consolidating everything into pyproject.toml anyway, we should consider switching to poetry. We'd be able to track all of our dependencies in pyproject.toml instead of requirements.txt and requirements-test.txt, use poetry's convenience features instead of having to manually manage venvs and using pip install --editable. The biggest advantage of this is that we'd no longer have to rely on setup.py.

Another option is rye, which is by the same co behind ruff, and bundles ruff. This would help us unify our CI completely. Rye is currently pre-1.0, which may be a concern.

(This is not a currently pressing concern, but there are minor inconveniences involved with setup.py and pip right now which can be vastly simplified.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant