Moved XLIFF constant strings to X.cs to avoid further typo.

Author: AlissaSabre

lrx/X.cs

@@ -36,6 +36,32 @@ public static class X
 
         public static readonly XName XSPACE = XNamespace.Xml + "space";
 
+        public static readonly XName DATATYPE = "datatype";
 
+        public static readonly XName ORIGINAL = "original";
+
+        public static readonly XName SOURCELANG = "source-language";
+
+        public static readonly XName TARGETLANG = "target-language";
+
+        public static readonly XName VERSION = "version";
+
+        public static readonly XName ID = "id";
+
+        public static readonly XName RESNAME = "resname";
+
+        public static readonly XName CTYPE = "context-type";
+
+        public const string PRESERVE = "preserve";
+
+        public const string LOCRES_NAME = "x-locres-namespace";
+
+        public const string LOCRES_KEY = "x-locres-key";
+
+        public const string LOCRES_HASH = "x-locres-hash";
+
+        public const string LOCRES_FORMAT_OLD = "x-locres-0";
+
+        public const string LOCRES_FORMAT_NEW = "x-locres-1";
     }
 }

lrx/XliffBuilder.cs

@@ -24,27 +24,27 @@ public class XliffBuilder
         public void Add(string name, string key, int hash, string source, string target)
         {
             Units.Add(new XElement(X.TU,
-                new XAttribute("id", id++),
-                new XAttribute("resname", key),
+                new XAttribute(X.ID, id++),
+                new XAttribute(X.RESNAME, key),
                 new XElement(X.SOURCE, new XAttribute(X.XLANG, SourceLang), source),
                 (target == null ? null : new XElement(X.TARGET, new XAttribute(X.XLANG, TargetLang), target)),
                 new XElement(X.CGROUP,
-                    (name == null ? null : new XElement(X.CONTEXT, new XAttribute("context-type", "x-locres-namespace"), name)),
-                    new XElement(X.CONTEXT, new XAttribute("context-type", "x-locres-key"), key),
-                    new XElement(X.CONTEXT, new XAttribute("context-type", "x-locres-hash"), hash.ToString("X08")))));
+                    (name == null ? null : new XElement(X.CONTEXT, new XAttribute(X.CTYPE, X.LOCRES_NAME), name)),
+                    new XElement(X.CONTEXT, new XAttribute(X.CTYPE, X.LOCRES_KEY), key),
+                    new XElement(X.CONTEXT, new XAttribute(X.CTYPE, X.LOCRES_HASH), hash.ToString("X08")))));
         }
 
         public XElement GetDocument()
         {
             return new XElement(X.XLIFF,
-                new XAttribute("version", "1.2"),
+                new XAttribute(X.VERSION, "1.2"),
                 new XAttribute(X.XNS, X.XLIFF_NS.NamespaceName),
                 new XElement(X.FILE,
-                    new XAttribute("original", Origin),
-                    new XAttribute("source-language", SourceLang),
-                    new XAttribute("target-language", TargetLang),
-                    new XAttribute("datatype", LocResFormat == LocResFormat.New ? "x-locres-1" : "x-locres-0"),
-                    new XAttribute(X.XSPACE, "preserve"),
+                    new XAttribute(X.ORIGINAL, Origin),
+                    new XAttribute(X.SOURCELANG, SourceLang),
+                    new XAttribute(X.TARGETLANG, TargetLang),
+                    new XAttribute(X.DATATYPE, LocResFormat == LocResFormat.New ? X.LOCRES_FORMAT_NEW : X.LOCRES_FORMAT_OLD),
+                    new XAttribute(X.XSPACE, X.PRESERVE),
                     new XElement(X.BODY,
                         Units)));
         }

lrx/XliffCruncher.cs

@@ -23,24 +23,24 @@ public void Read(string filename)
         public LocRes Crunch()
         {
             LocResFormat format = LocResFormat.Auto;
-            switch ((string)Xliff.Element(X.FILE).Attribute("datatype"))
+            switch ((string)Xliff.Element(X.FILE).Attribute(X.DATATYPE))
             {
-                case "x-locres-0": format = LocResFormat.Old; break;
-                case "x-locres-1": format = LocResFormat.New; break;
+                case X.LOCRES_FORMAT_OLD: format = LocResFormat.Old; break;
+                case X.LOCRES_FORMAT_NEW: format = LocResFormat.New; break;
             }
 
-            var names = Xliff.Descendants(X.TU).Select(tu => GetContext(tu, "x-locres-namespace")).Distinct().ToArray();
+            var names = Xliff.Descendants(X.TU).Select(tu => GetContext(tu, X.LOCRES_NAME)).Distinct().ToArray();
             var tables = new List<LocRes.Table>(names.Length);
             foreach (var n in names)
             {
                 var entries = new List<LocRes.Entry>();
-                foreach (var tu in Xliff.Descendants(X.TU).Where(tu => GetContext(tu, "x-locres-namespace") == n))
+                foreach (var tu in Xliff.Descendants(X.TU).Where(tu => GetContext(tu, X.LOCRES_NAME) == n))
                 {
                     var text = (string)tu.Element(X.TARGET);
                     if (text == null) continue;
 
-                    var key = GetContext(tu, "x-locres-key");
-                    var hash_text = GetContext(tu, "x-locres-hash");
+                    var key = GetContext(tu, X.LOCRES_KEY);
+                    var hash_text = GetContext(tu, X.LOCRES_HASH);
                     if (key == null || hash_text == null) throw new FormatException();
                     int hash;
                     if (!int.TryParse(hash_text, NumberStyles.HexNumber, CultureInfo.InvariantCulture, out hash))
@@ -64,7 +64,7 @@ public LocRes Crunch()
         /// <returns>Content string of a context element whose context-type matches <paramref name="context_type"/>, or null if no such context exists.</returns>
         private static string GetContext(XElement tu, string context_type)
         {
-            return (string)tu.Element(X.CGROUP)?.Elements(X.CONTEXT)?.FirstOrDefault(c => (string)c.Attribute("context-type") == context_type);
+            return (string)tu.Element(X.CGROUP)?.Elements(X.CONTEXT)?.FirstOrDefault(c => (string)c.Attribute(X.CTYPE) == context_type);
         }
     }
 }