[Common] Fix compilation warnings (#8379)

Author: vkucera

Common/Core/TPCVDriftManager.h

@@ -116,8 +116,8 @@ class TPCVDriftManager
     if (dDriftErr < 0.f || dDrift > 250.f) { // we cannot move a track outside the drift volume
       if (mOutside < mWarningLimit) {
         LOGP(warn, "Skipping correction outside of tpc volume with dDrift={} +- {}", dDrift, dDriftErr);
-        const auto& trackBC = trackExtra.template collision_as<Collisions>().template foundBC_as<BCs>().globalBC();
-        const auto& colBC = col.template foundBC_as<BCs>().globalBC();
+        const auto trackBC = trackExtra.template collision_as<Collisions>().template foundBC_as<BCs>().globalBC();
+        const auto colBC = col.template foundBC_as<BCs>().globalBC();
         int diffBC = colBC - trackBC;
         LOGP(info, "ct={}; ctr={}; tTB={}; t0={}; dTime={}; dDrift={}; tgl={}:   colBC={}   trackBC={}  diffBC={}", col.collisionTime(), col.collisionTimeRes(), tTB, trackExtra.trackTime(), dTime, dDrift, track.getTgl(), colBC, trackBC, diffBC);
         if (mOutside == mWarningLimit - 1) {

Common/TableProducer/Converters/bcFlagsCreator.cxx

@@ -22,7 +22,7 @@ struct bcFlagsCreator {
 
   void process(aod::BCs const& bcTable)
   {
-    for (auto& _ : bcTable) {
+    for (int64_t i = 0; i < bcTable.size(); ++i) {
       bcFlags(0);
     }
   }

Common/TableProducer/mcCollsExtra.cxx

@@ -12,9 +12,10 @@
 // Quick and dirty task to correlate MC <-> data
 //
 
-#include <cmath>
 #include <array>
+#include <cmath>
 #include <cstdlib>
+#include <vector>
 
 #include "Math/Vector4D.h"
 #include <TFile.h>
@@ -135,8 +136,8 @@ struct mcCollisionExtra {
       auto iter = std::find(sortedIndices.begin(), sortedIndices.end(), mcCollision.index());
       if (iter != sortedIndices.end()) {
         auto index = std::distance(iter, sortedIndices.begin());
-        for (size_t iMcColl = index + 1; iMcColl < index + 17; iMcColl++) {
-          if (iMcColl >= sortedIndices.size())
+        for (auto iMcColl = index + 1; iMcColl < index + 17; iMcColl++) {
+          if (iMcColl >= std::ssize(sortedIndices))
             continue;
           if (mcCollisionHasPoI[sortedIndices[iMcColl]])
             bitset(forwardHistory, iMcColl - index - 1);