Avoid magic numbers

Author: ariffero

PWGUD/Tasks/FwdMuonsUPC.cxx

@@ -172,6 +172,11 @@ float kEtaMin = -4.0;
 float kEtaMax = -2.5;
 const float kPtMin = 0.;
 
+const float kMaxAmpV0A = 100.;
+const int kReqMatchMIDTracks = 2;
+const int kReqMatchMFTTracks = 2;
+const int kMaxChi2MFTMatch = 30;
+
 struct FwdMuonsUPC {
 
   // a pdg object
@@ -482,18 +487,18 @@ struct FwdMuonsUPC {
   // function to compute phi for azimuth anisotropy
   void computePhiAnis(TLorentzVector p1, TLorentzVector p2, int sign1, float& phiAverage, float& phiCharge)
   {
-
     TLorentzVector tSum, tDiffAv, tDiffCh;
     tSum = p1 + p2;
+    float halfUnity = 0.5;
     if (sign1 > 0) {
       tDiffCh = p1 - p2;
-      if (gRandom->Rndm() > 0.5)
+      if (gRandom->Rndm() > halfUnity)
         tDiffAv = p1 - p2;
       else
         tDiffAv = p2 - p1;
     } else {
       tDiffCh = p2 - p1;
-      if (gRandom->Rndm() > 0.5)
+      if (gRandom->Rndm() > halfUnity)
         tDiffAv = p2 - p1;
       else
         tDiffAv = p1 - p2;
@@ -518,7 +523,7 @@ struct FwdMuonsUPC {
     const auto& ampsRelBCsV0A = cand.ampRelBCsV0A();
     for (unsigned int i = 0; i < ampsV0A.size(); ++i) {
       if (std::abs(ampsRelBCsV0A[i]) <= 1) {
-        if (ampsV0A[i] > 100.)
+        if (ampsV0A[i] > kMaxAmpV0A)
           return;
       }
     }
@@ -535,7 +540,7 @@ struct FwdMuonsUPC {
       nMIDs++;
     if (tr2.chi2MatchMCHMID() > 0)
       nMIDs++;
-    if (nMIDs != 2)
+    if (nMIDs != kReqMatchMIDTracks)
       return;
 
     // MFT-MID match selection (if MFT is requested by the trackType)
@@ -545,11 +550,11 @@ struct FwdMuonsUPC {
       kEtaMax = -2.5;
 
       int nMFT = 0;
-      if (tr1.chi2MatchMCHMFT() > 0 && tr1.chi2MatchMCHMFT() < 30)
+      if (tr1.chi2MatchMCHMFT() > 0 && tr1.chi2MatchMCHMFT() < kMaxChi2MFTMatch)
         nMFT++;
-      if (tr2.chi2MatchMCHMFT() > 0 && tr2.chi2MatchMCHMFT() < 30)
+      if (tr2.chi2MatchMCHMFT() > 0 && tr2.chi2MatchMCHMFT() < kMaxChi2MFTMatch)
         nMFT++;
-      if (nMFT != 2)
+      if (nMFT != kReqMatchMFTTracks)
         return;
     }
 
@@ -778,7 +783,7 @@ struct FwdMuonsUPC {
       nMIDs++;
     if (tr2.chi2MatchMCHMID() > 0)
       nMIDs++;
-    if (nMIDs != 2)
+    if (nMIDs != kReqMatchMIDTracks)
       return;
 
     // MFT-MID match selection (if MFT is requested by the trackType)
@@ -788,11 +793,11 @@ struct FwdMuonsUPC {
       kEtaMax = -2.5;
 
       int nMFT = 0;
-      if (tr1.chi2MatchMCHMFT() > 0 && tr1.chi2MatchMCHMFT() < 30)
+      if (tr1.chi2MatchMCHMFT() > 0 && tr1.chi2MatchMCHMFT() < kMaxChi2MFTMatch)
         nMFT++;
-      if (tr2.chi2MatchMCHMFT() > 0 && tr2.chi2MatchMCHMFT() < 30)
+      if (tr2.chi2MatchMCHMFT() > 0 && tr2.chi2MatchMCHMFT() < kMaxChi2MFTMatch)
         nMFT++;
-      if (nMFT != 2)
+      if (nMFT != kReqMatchMFTTracks)
         return;
     }