[PWGHF] Extend information of sparses for efficiency evaluation. Refactor analysis utilities. #2134
MarcellocostiAnnotations
2 errors, 10 warnings, and 1 notice
|
O2 linter result
Issues have been found.
|
|
O2 linter
Process completed with exit code 1.
|
|
[two-pi-add-subtract]:
PWGHF/D2H/Tasks/taskFlowCharmHadrons.cxx#L256
Consider using RecoDecay::constrainAngle to restrict angle to a given range.
|
|
[two-pi-add-subtract]:
PWGHF/D2H/Tasks/taskFlowCharmHadrons.cxx#L258
Consider using RecoDecay::constrainAngle to restrict angle to a given range.
|
|
[pwghf/struct-member-order]:
PWGHF/D2H/Tasks/taskFlowCharmHadrons.cxx#L117
HfTaskFlowCharmHadrons: SliceCache appears too early (before end of HfHelper).
|
|
[pwghf/struct-member-order]:
PWGHF/D2H/Tasks/taskFlowCharmHadrons.cxx#L89
HfTaskFlowCharmHadrons: using appears too early (before end of SliceCache).
|
|
[pwghf/struct-member-order]:
PWGHF/D2H/Tasks/taskFlowCharmHadrons.cxx#L73
HfTaskFlowCharmHadrons: ConfigurableAxis appears too early (before end of Partition<).
|
|
[pwghf/struct-member-order]:
PWGHF/D2H/Tasks/taskFlowCharmHadrons.cxx#L1
Declare struct members in the conventional order. See the PWGHF coding guidelines.
|
|
[name/function-variable]:
PWGHF/TableProducer/candidateCreator2Prong.cxx#L374
Use lowerCamelCase for names of functions and variables.
|
|
[name/macro]:
PWGHF/TableProducer/candidateCreator2Prong.cxx#L20
Use SCREAMING_SNAKE_CASE for names of macros. Leading and double underscores are not allowed.
|
|
[name/o2-task]:
PWGHF/TableProducer/candidateCreator2Prong.cxx#L904
Device names hf-candidate-creator-2prong and hf-candidate-creator2-prong generated from the specified task name hf-candidate-creator-2prong and from the struct name HfCandidateCreator2Prong, respectively, differ in hyphenation. Consider fixing capitalisation of the struct name to HfCandidateCreator2Prong and removing TaskName.
|
|
[name/o2-task]:
PWGHF/TableProducer/candidateCreator2Prong.cxx#L905
Device names hf-candidate-creator-2prong-expressions and hf-candidate-creator2-prong-expressions generated from the specified task name hf-candidate-creator-2prong-expressions and from the struct name HfCandidateCreator2ProngExpressions, respectively, differ in hyphenation. Consider fixing capitalisation of the struct name to HfCandidateCreator2ProngExpressions and removing TaskName.
|
|
O2 linter
You can disable a test for a line by adding a comment with "o2-linter: disable=" followed by the name of the test.
|