Skip to content

Commit 619ef88

Browse files
author
Niveditha Ramasubramanian
committed
making small changes to make code more stable
1 parent fc8a064 commit 619ef88

File tree

2 files changed

+14
-18
lines changed

2 files changed

+14
-18
lines changed

DataFormats/Detectors/ITSMFT/common/include/DataFormatsITSMFT/NoiseMap.h

Lines changed: 6 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,4 @@
1+
12
// Copyright 2019-2020 CERN and copyright holders of ALICE O2.
23
// See https://alice-o2.web.cern.ch/copyright for details of the copyright holders.
34
// All rights not expressly granted are reserved.
@@ -202,23 +203,15 @@ class NoiseMap
202203
return std::ceil((1. + 1. / t) / (relErr * relErr));
203204
}
204205

205-
NoiseMap merge(NoiseMap* prev)
206+
NoiseMap merge(const NoiseMap* prev)
206207
{
207208
int incre = 0;
208209
for (size_t i = 0; i < (int)mNoisyPixels.size(); ++i) {
209210
for (const auto& prev_np : prev->mNoisyPixels[i]) { // only enters this for loop if the "i" chip exists.
210-
bool existsInCurrentMap = false;
211-
for (const auto& current_np : mNoisyPixels[i]) {
212-
if (prev_np.first == current_np.first) {
213-
existsInCurrentMap = true;
214-
break;
215-
}
216-
} // end of for loop on elements of previous noise map
217-
218-
if (!existsInCurrentMap) {
219-
incre++;
220-
mNoisyPixels[i][prev_np.first] = prev_np.second;
221-
}
211+
if (mNoisyPixels[i].find(prev_np.first) == mNoisyPixels[i].end()) {
212+
mNoisyPixels[i][prev_np.first] = prev_np.second;
213+
incre++;
214+
}
222215
} // end of for loop on elements of previous noise map
223216
} // end of for loop on i (chip ID)
224217
return (mNoisyPixels);

Detectors/ITSMFT/MFT/calibration/src/NoiseCalibratorSpec.cxx

Lines changed: 8 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -299,11 +299,14 @@ void NoiseCalibratorSpec::sendOutputCcdbMerge(DataAllocator& output)
299299
map<std::string, std::string> filter;
300300
auto* payloadPrev1 = api.retrieveFromTFileAny<o2::itsmft::NoiseMap>(mPath, filter, -1, &headers);
301301
long validtime = std::stol(headers["Valid-From"]);
302-
validtime = validtime - 60;
303-
auto* payloadPrev2 = api.retrieveFromTFileAny<o2::itsmft::NoiseMap>(mPath, filter, validtime, &headers);
304-
auto bufferPL = payloadPrev2->merge(payloadPrev1);
305-
auto mergedPL = payload.merge(&bufferPL);
306-
// payload.merge(payloadPrev);
302+
auto mergedPL = payload;
303+
if(validtime>0)
304+
{
305+
validtime = validtime - 60;
306+
auto* payloadPrev2 = api.retrieveFromTFileAny<o2::itsmft::NoiseMap>(mPath, filter, validtime, &headers);
307+
auto bufferPL = payloadPrev2->merge(payloadPrev1);
308+
mergedPL = payload.merge(&bufferPL);
309+
}
307310
o2::ccdb::CcdbObjectInfo info(mPathMerge, "NoiseMap", "noise.root", meta, tstart, tend);
308311
auto flName = o2::ccdb::CcdbApi::generateFileName("noise");
309312
auto image = o2::ccdb::CcdbApi::createObjectImage(&mergedPL, &info);

0 commit comments

Comments
 (0)