Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[feature-1] staircase_search.cpp #539

Merged
merged 6 commits into from
Apr 1, 2021
Merged

[feature-1] staircase_search.cpp #539

merged 6 commits into from
Apr 1, 2021

Conversation

kiruba-r11
Copy link
Contributor

Closes: #385

Implemented the StairCase Search in C++

  • Code is well-formatted
  • Code is well commented
  • Code is not plagiarised
  • Code is placed in the proper folder
  • readme.md of 2D_Array is updated with the code link

@kiruba-r11
Copy link
Contributor Author

@tarun26091999 Please review this and suggest me any changes if required.

tarun26091999
tarun26091999 requested changes Mar 11, 2021
View reviewed changes
Copy link
Member

@tarun26091999 tarun26091999 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it need to be linked in the searching folder. Also add comments to explain your steps.

@kiruba-r11
Copy link
Contributor Author

@tarun26091999 I have added comments to my code. And, I am not sure about which searching folder you are saying. Is it the one inside the Algorithms folder? If so, can you please explain to me in detail what changes do I have to make in that folder?

@kiruba-r11
Copy link
Contributor Author

@tarun26091999 Can you please guide me regarding the comment I gave above

@kiruba-r11
Copy link
Contributor Author

@tarun26091999 Please review this

2 similar comments
@kiruba-r11
Copy link
Contributor Author

@tarun26091999 Please review this

@kiruba-r11
Copy link
Contributor Author

@tarun26091999 Please review this

@kiruba-r11
Copy link
Contributor Author

@rudrakshi99 Can you please review this

@rudrakshi99
Copy link
Member

@tarun26091999 I have added comments to my code. And, I am not sure about which searching folder you are saying. Is it the one inside the Algorithms folder? If so, can you please explain to me in detail what changes do I have to make in that folder?

this one - https://github.com/Algo-Phantoms/Algo-Tree/tree/main/Algorithm/Searching_Sorting

@kiruba-r11
Copy link
Contributor Author

@rudrakshi99 I made the changes. Suggest me any more changes if required

OjusWiZard
OjusWiZard requested changes Mar 31, 2021
View reviewed changes
Copy link
Collaborator

@OjusWiZard OjusWiZard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please use 4 spaces for indentation.

@kiruba-r11
Copy link
Contributor Author

@OjusWiZard I have already used 4 spaces only. Please do check it again

@kiruba-r11
Copy link
Contributor Author

@OjusWiZard Please recheck it again. It has been more than 20 days waiting for this PR to get reviewed

OjusWiZard
OjusWiZard approved these changes Apr 1, 2021
View reviewed changes
Copy link
Collaborator

@OjusWiZard OjusWiZard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, we have updated our guidelines for the indentation now.
Good work!

@OjusWiZard OjusWiZard added gssoc21 Girlscript summer of code 2021 Level1 medium labels Apr 1, 2021
@OjusWiZard OjusWiZard merged commit e91e4a8 into Algo-Phantoms:main Apr 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@OjusWiZard OjusWiZard OjusWiZard approved these changes

@rudrakshi99 rudrakshi99 rudrakshi99 approved these changes

@tarun26091999 tarun26091999 tarun26091999 approved these changes

Assignees
No one assigned
Labels
gssoc21 Girlscript summer of code 2021 Level1 medium
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

StairCase Search in 2D Arrays
4 participants
@kiruba-r11 @rudrakshi99 @tarun26091999 @OjusWiZard