Skip to content

Fixes the reported issue #371 #372

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 28, 2025
Merged

Fixes the reported issue #371 #372

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3886778
Fixes the reported issue #371
anyzelman Jul 25, 2025
7241097
Add no-op check to dense path of eWiseApply
anyzelman Jul 25, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions include/graphblas/ops.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -76,7 +76,8 @@ namespace grb {
*
* \warning Therefore, this operator may propagate the use of uninitialised
* values if not used with care. Ensuring its use with in-place
* primitives is recommended.
* primitives is recommended; it should \em not be used with
* #grb::eWiseApply.
*/
template<
typename D1, typename D2 = D1, typename D3 = D2,
Expand Down Expand Up @@ -132,7 +133,8 @@ namespace grb {
*
* \warning Therefore, this operator may propagate the use of uninitialised
* values if not used with care. Ensuring its use with in-place
* primitives is recommended.
* primitives is recommended; it should \em not be used with
* #grb::eWiseApply.
*/
template<
typename D1, typename D2 = D1, typename D3 = D2,
Expand Down
15 changes: 12 additions & 3 deletions include/graphblas/reference/blas1.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2974,6 +2974,13 @@ namespace grb {
) {
#ifdef _DEBUG
std::cout << "\t internal::dense_apply_generic called\n";
#endif
#ifndef GRB_NO_NOOP_CHECKS
static_assert(
!internal::maybe_noop< OP >::value,
"Warning: you may be generating an output vector with uninitialised values."
" (Define the GRB_NO_NOOP_CHECKS macro to disable this check.)\n"
);
#endif
static_assert( !(left_scalar && left_sparse),
"The left-hand side must be scalar OR sparse, but cannot be both!" );
Expand Down Expand Up @@ -3132,9 +3139,11 @@ namespace grb {
(void) n;
#endif
#ifndef GRB_NO_NOOP_CHECKS
static_assert( !internal::maybe_noop< OP >::value, "Warning: you may be "
"generating an output vector with uninitialised values. Define "
"the GRB_NO_NOOP_CHECKS macro to disable this check.\n" );
static_assert(
(descr & descriptors::dense) || !internal::maybe_noop< OP >::value,
"Warning: you may be generating an output vector with uninitialised values."
" (Define the GRB_NO_NOOP_CHECKS macro to disable this check.)\n"
);
#endif
// assertions
assert( !masked || mask_coors != nullptr );
Expand Down