Skip to content

Commit bfdbb22

Browse files
committed
Minor code style change and make it easier to trace bugs (by adding asserts on return codes)
1 parent c3fda7f commit bfdbb22

File tree

1 file changed

+27
-1
lines changed

1 file changed

+27
-1
lines changed

tests/unit/ewiseapply.cpp

Lines changed: 27 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,7 @@
2222

2323
using namespace grb;
2424

25-
void grb_program( const size_t & n, grb::RC & rc ) {
25+
void grb_program( const size_t &n, grb::RC &rc ) {
2626
grb::Vector< double > out( n ), left( n ), right( n );
2727
grb::Vector< bool > mask( n );
2828
grb::Vector< size_t > temp( n );
@@ -59,6 +59,7 @@ void grb_program( const size_t & n, grb::RC & rc ) {
5959

6060
// test operator versions first, dense vectors only, without masks
6161
rc = grb::eWiseApply( out, left, 0.25, plusM.getOperator() );
62+
assert( rc == SUCCESS );
6263
if( rc == SUCCESS ) {
6364
if( nnz( out ) != size( out ) ) {
6465
std::cerr << "\tunexpected number of nonzeroes ( " << nnz( out ) << " ), "
@@ -81,6 +82,7 @@ void grb_program( const size_t & n, grb::RC & rc ) {
8182
}
8283

8384
rc = grb::eWiseApply( out, 0.25, left, plusM.getOperator() );
85+
assert( rc == SUCCESS );
8486
if( rc == SUCCESS ) {
8587
if( nnz( out ) != size( out ) ) {
8688
std::cerr << "\tunexpected number of nonzeroes ( " << nnz( out ) << ", "
@@ -102,6 +104,7 @@ void grb_program( const size_t & n, grb::RC & rc ) {
102104
}
103105

104106
rc = grb::eWiseApply( out, left, left, plusM.getOperator() );
107+
assert( rc == SUCCESS );
105108
if( rc == SUCCESS ) {
106109
if( nnz( out ) != size( out ) ) {
107110
std::cerr << "\tunexpected number of nonzeroes ( " << nnz( out ) << ", "
@@ -124,6 +127,7 @@ void grb_program( const size_t & n, grb::RC & rc ) {
124127

125128
// operator versions, dense vectors only, with masks
126129
rc = grb::eWiseApply( out, mask, left, 0.25, plusM.getOperator() );
130+
assert( rc == SUCCESS );
127131
if( rc == SUCCESS ) {
128132
if( grb::nnz( out ) != grb::nnz( mask ) ) {
129133
std::cerr << "\tunexpected number of nonzeroes ( " << grb::nnz( out )
@@ -150,7 +154,9 @@ void grb_program( const size_t & n, grb::RC & rc ) {
150154
} else {
151155
return;
152156
}
157+
153158
rc = grb::eWiseApply( out, mask, 0.25, left, plusM.getOperator() );
159+
assert( rc == SUCCESS );
154160
if( rc == SUCCESS ) {
155161
if( grb::nnz( out ) != grb::nnz( mask ) ) {
156162
std::cerr << "\tunexpected number of nonzeroes ( " << grb::nnz( out )
@@ -176,7 +182,9 @@ void grb_program( const size_t & n, grb::RC & rc ) {
176182
} else {
177183
return;
178184
}
185+
179186
rc = grb::eWiseApply( out, mask, left, left, plusM.getOperator() );
187+
assert( rc == SUCCESS );
180188
if( rc == SUCCESS ) {
181189
if( grb::nnz( out ) != grb::nnz( mask ) ) {
182190
std::cerr << "\tunexpected number of nonzeroes ( " << grb::nnz( out )
@@ -205,6 +213,7 @@ void grb_program( const size_t & n, grb::RC & rc ) {
205213

206214
// monoid version, dense vectors, unmasked
207215
rc = grb::eWiseApply( out, left, 0.25, plusM );
216+
assert( rc == SUCCESS );
208217
if( rc == SUCCESS ) {
209218
if( nnz( out ) != size( out ) ) {
210219
std::cerr << "\tunexpected number of nonzeroes ( " << nnz( out ) << ", "
@@ -226,6 +235,7 @@ void grb_program( const size_t & n, grb::RC & rc ) {
226235
}
227236

228237
rc = grb::eWiseApply( out, 0.25, left, plusM );
238+
assert( rc == SUCCESS );
229239
if( rc == SUCCESS ) {
230240
if( nnz( out ) != size( out ) ) {
231241
std::cerr << "\tunexpected number of nonzeroes ( " << nnz( out ) << ", "
@@ -247,6 +257,7 @@ void grb_program( const size_t & n, grb::RC & rc ) {
247257
}
248258

249259
rc = grb::eWiseApply( out, left, left, plusM.getOperator() );
260+
assert( rc == SUCCESS );
250261
if( rc == SUCCESS ) {
251262
if( nnz( out ) != size( out ) ) {
252263
std::cerr << "\tunexpected number of nonzeroes ( " << nnz( out )
@@ -269,6 +280,7 @@ void grb_program( const size_t & n, grb::RC & rc ) {
269280

270281
// monoid versions, dense vectors, with masks
271282
rc = grb::eWiseApply( out, mask, left, 0.25, plusM );
283+
assert( rc == SUCCESS );
272284
if( rc == SUCCESS ) {
273285
if( grb::nnz( out ) != grb::nnz( mask ) ) {
274286
std::cerr << "\tunexpected number of nonzeroes ( " << grb::nnz( out )
@@ -294,7 +306,9 @@ void grb_program( const size_t & n, grb::RC & rc ) {
294306
} else {
295307
return;
296308
}
309+
297310
rc = grb::eWiseApply( out, mask, 0.25, left, plusM );
311+
assert( rc == SUCCESS );
298312
if( rc == SUCCESS ) {
299313
if( grb::nnz( out ) != grb::nnz( mask ) ) {
300314
std::cerr << "\tunexpected number of nonzeroes ( " << grb::nnz( out )
@@ -320,7 +334,9 @@ void grb_program( const size_t & n, grb::RC & rc ) {
320334
} else {
321335
return;
322336
}
337+
323338
rc = grb::eWiseApply( out, mask, left, left, plusM );
339+
assert( rc == SUCCESS );
324340
if( rc == SUCCESS ) {
325341
if( grb::nnz( out ) != grb::nnz( mask ) ) {
326342
std::cerr << "\tunexpected number of nonzeroes ( " << grb::nnz( out )
@@ -349,6 +365,7 @@ void grb_program( const size_t & n, grb::RC & rc ) {
349365

350366
// monoid version, sparse vectors, unmasked
351367
rc = grb::eWiseApply( out, right, 0.25, plusM );
368+
assert( rc == SUCCESS );
352369
if( rc == SUCCESS ) {
353370
if( nnz( out ) != size( out ) ) {
354371
std::cerr << "\tunexpected number of nonzeroes ( " << nnz( out ) << ", "
@@ -378,6 +395,7 @@ void grb_program( const size_t & n, grb::RC & rc ) {
378395
}
379396

380397
rc = grb::eWiseApply( out, 0.25, right, plusM );
398+
assert( rc == SUCCESS );
381399
if( rc == SUCCESS ) {
382400
if( nnz( out ) != size( out ) ) {
383401
std::cerr << "\tunexpected number of nonzeroes ( " << nnz( out ) << " ), "
@@ -407,6 +425,7 @@ void grb_program( const size_t & n, grb::RC & rc ) {
407425
}
408426

409427
rc = grb::eWiseApply( out, left, right, plusM );
428+
assert( rc == SUCCESS );
410429
if( rc == SUCCESS ) {
411430
if( nnz( out ) != size( out ) ) {
412431
std::cerr << "\tunexpected number of nonzeroes ( " << nnz( out ) << " ), "
@@ -436,6 +455,7 @@ void grb_program( const size_t & n, grb::RC & rc ) {
436455
}
437456

438457
rc = grb::eWiseApply( out, right, left, plusM );
458+
assert( rc == SUCCESS );
439459
if( rc == SUCCESS ) {
440460
if( nnz( out ) != size( right ) ) {
441461
std::cerr << "\tunexpected number of nonzeroes ( " << nnz( out ) << ", "
@@ -465,6 +485,7 @@ void grb_program( const size_t & n, grb::RC & rc ) {
465485
}
466486

467487
rc = grb::eWiseApply( out, right, right, plusM );
488+
assert( rc == SUCCESS );
468489
if( rc == SUCCESS ) {
469490
if( nnz( out ) != nnz( right ) ) {
470491
std::cerr << "\tunexpected number of nonzeroes ( " << nnz( out ) << ", "
@@ -493,6 +514,7 @@ void grb_program( const size_t & n, grb::RC & rc ) {
493514

494515
// monoid version, sparse vectors, with masks
495516
rc = grb::eWiseApply( out, mask, right, 0.25, plusM );
517+
assert( rc == SUCCESS );
496518
if( rc == SUCCESS ) {
497519
if( nnz( out ) != size( out ) / 2 ) {
498520
std::cerr << "\tunexpected number of nonzeroes ( " << nnz( out ) << ", "
@@ -528,6 +550,7 @@ void grb_program( const size_t & n, grb::RC & rc ) {
528550
}
529551

530552
rc = grb::eWiseApply( out, mask, 0.25, right, plusM );
553+
assert( rc == SUCCESS );
531554
if( rc == SUCCESS ) {
532555
if( nnz( out ) != size( out ) / 2 ) {
533556
std::cerr << "\tunexpected number of nonzeroes ( " << nnz( out ) << ", "
@@ -563,6 +586,7 @@ void grb_program( const size_t & n, grb::RC & rc ) {
563586
}
564587

565588
rc = grb::eWiseApply( out, mask, left, right, plusM );
589+
assert( rc == SUCCESS );
566590
if( rc == SUCCESS ) {
567591
if( nnz( out ) != size( out ) / 2 ) {
568592
std::cerr << "\tunexpected number of nonzeroes ( " << nnz( out ) << ", "
@@ -598,6 +622,7 @@ void grb_program( const size_t & n, grb::RC & rc ) {
598622
}
599623

600624
rc = grb::eWiseApply( out, mask, right, left, plusM );
625+
assert( rc == SUCCESS );
601626
if( rc == SUCCESS ) {
602627
if( nnz( out ) != size( right ) / 2 ) {
603628
std::cerr << "\tunexpected number of nonzeroes ( " << nnz( out ) << ", "
@@ -633,6 +658,7 @@ void grb_program( const size_t & n, grb::RC & rc ) {
633658
}
634659

635660
rc = grb::eWiseApply( out, mask, right, right, plusM );
661+
assert( rc == SUCCESS );
636662
if( rc == SUCCESS ) {
637663
if( nnz( out ) != nnz( right ) / 2 ) {
638664
std::cerr << "\tunexpected number of nonzeroes ( " << nnz( out ) << ", "

0 commit comments

Comments
 (0)