diff --git a/Tools/clinic/clinic.py b/Tools/clinic/clinic.py index 7525c1ca5240034..568cf419ff2c0ab 100755 --- a/Tools/clinic/clinic.py +++ b/Tools/clinic/clinic.py @@ -884,9 +884,7 @@ def output_templates( converters = [p.converter for p in parameters] has_option_groups = parameters and (parameters[0].group or parameters[-1].group) - default_return_converter = (not f.return_converter or - f.return_converter.type == 'PyObject *') - + default_return_converter = f.return_converter.type == 'PyObject *' new_or_init = f.kind.new_or_init vararg: int | str = NO_VARARG @@ -4422,7 +4420,7 @@ class DSLParser: keyword_only: bool positional_only: bool group: int - parameter_state: int + parameter_state: ParamState seen_positional_with_default: bool indent: IndentStack kind: FunctionKind @@ -4776,8 +4774,6 @@ def state_modulename_name(self, line: str) -> None: if not return_converter: return_converter = CReturnConverter() - if not module: - fail("Undefined module used in declaration of " + repr(full_name.strip()) + ".") self.function = Function(name=function_name, full_name=full_name, module=module, cls=cls, c_basename=c_basename, return_converter=return_converter, kind=self.kind, coexist=self.coexist) self.block.signatures.append(self.function) diff --git a/Tools/clinic/mypy.ini b/Tools/clinic/mypy.ini index 4cfc05bec01608e..b1fdad673c61a10 100644 --- a/Tools/clinic/mypy.ini +++ b/Tools/clinic/mypy.ini @@ -8,5 +8,5 @@ python_version = 3.10 # and be strict! strict = True strict_concatenate = True -enable_error_code = ignore-without-code,redundant-expr +enable_error_code = ignore-without-code,redundant-expr,truthy-bool warn_unreachable = True