From 377d5987c67f220c537bb48266b42b5cfd89c0e3 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Robin=20Bo=CC=88ning?= Date: Sat, 12 Dec 2020 16:47:23 +0100 Subject: [PATCH] Extend and restructure LegacyPageUrl spec --- spec/models/alchemy/legacy_page_url_spec.rb | 22 +++++++++++---------- 1 file changed, 12 insertions(+), 10 deletions(-) diff --git a/spec/models/alchemy/legacy_page_url_spec.rb b/spec/models/alchemy/legacy_page_url_spec.rb index 857f1ebf01..7a5685a9de 100644 --- a/spec/models/alchemy/legacy_page_url_spec.rb +++ b/spec/models/alchemy/legacy_page_url_spec.rb @@ -5,20 +5,22 @@ describe Alchemy::LegacyPageUrl do let(:page) { build_stubbed(:alchemy_page) } - let(:page_url_with_parameters) do - Alchemy::LegacyPageUrl.new(urlname: "index.php?id=2", page: page) - end - - let(:valid_page_url) do - Alchemy::LegacyPageUrl.new(urlname: "my/0-work+is-nice_stuff", page: page) + it "is invalid with invalid URL characters" do + expect( + Alchemy::LegacyPageUrl.new(urlname: "{bar}", page: page) + ).to be_invalid end - it "is only valid with correct urlname format" do - expect(valid_page_url).to be_valid + it "is valid with correct urlname format" do + expect( + Alchemy::LegacyPageUrl.new(urlname: "my/0-work+is-nice_stuff", page: page) + ).to be_valid end - it "is also valid with get parameters in urlname" do - expect(page_url_with_parameters).to be_valid + it "is valid with get parameters in urlname" do + expect( + Alchemy::LegacyPageUrl.new(urlname: "index.php?id=2", page: page) + ).to be_valid end it "is valid with pound sign in urlname" do