Conversation
Member
Author
|
The vast majority of these changes are the Rails 5 updates of the dummy app. |
mamhoff
approved these changes
Jul 16, 2017
Contributor
mamhoff
left a comment
mamhoff
left a comment
There was a problem hiding this comment.
Go for it, I see no blockers here.
These versions support Rails 5
Some specs are depending on it.
We tackle deprecations later
Rails 5 controller tests does not work with rspec request stubs anymore. Needed to stub ActionController::TestRequest instead.
In order to test deliver_later properly we use the test queue adapter.
- Only build ruby versions that are compatible with Rails 5 - Uses trusty distro
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updates to Alchemy 4 and Devise 4 with support for Rails 5.