changed TypeError with custom UnidentifiableSubclassError, and changed version to 0.3.0

Author: Alchemy-Meister

src/design_pytterns/_about.py

@@ -12,4 +12,4 @@
 __license__ = 'GPL-3.0-or-later'
 __title__ = 'design-pytterns'
 __url__ = 'https://github.com/Alchemy-Meister/python-design-patterns'
-__version__ = '0.2.0'
+__version__ = '0.3.0'

src/design_pytterns/_helpers/concrete_subclass_register.py

@@ -11,6 +11,7 @@
 import logging
 from typing import MutableMapping, Type
 
+from design_pytterns.errors import UnidentifiableSubclassError
 from design_pytterns.interfaces import SubclassIdentifiable
 
 
@@ -30,18 +31,19 @@ class ConcreteSubclassRegister():
 
     Raises
     ------
-    TypeError
+    UnidentifiableSubclassError
         If `base_class` does not inherit from SubclassIdentifiable.
 
+    .. versionchanged:: 0.3.0 raises `UnidentifiableSubclassError` instead of
+            `TypeError`.
+
     """
 
     __LOGGER = logging.getLogger(__name__)
 
     def __init__(self, base_class: Type[SubclassIdentifiable]) -> None:
         if not issubclass(base_class, SubclassIdentifiable):
-            raise TypeError(
-                f'unidentifiable base class: {repr(base_class.__name__)}'
-            )
+            raise UnidentifiableSubclassError(base_class)
 
         self.registered_classes = self._register_subclasses(base_class)
 

src/design_pytterns/errors/__init__.py

@@ -7,6 +7,11 @@
 """Subpackage with the exception definitions."""
 
 from .design_pyttern_error import DesignPytternError
+from .unidentifiable_subclass_error import UnidentifiableSubclassError
 from .unregistered_class_id_error import UnregisteredClassIdError
 
-__all__ = ['DesignPytternError', 'UnregisteredClassIdError']
+__all__ = [
+    'DesignPytternError',
+    'UnidentifiableSubclassError',
+    'UnregisteredClassIdError'
+]

src/design_pytterns/errors/unidentifiable_subclass_error.py

@@ -0,0 +1,26 @@
+#! /usr/bin/env python3
+
+# SPDX-FileCopyrightText: 2020 Alchemy-Meister
+#
+# SPDX-License-Identifier: GPL-3.0-or-later
+
+"""Unidentifiable subclass error."""
+
+from .design_pyttern_error import DesignPytternError
+
+
+class UnidentifiableSubclassError(DesignPytternError):
+    """
+    Raised when the base class of a subclass register is not identifiable.
+
+    Parameters
+    ----------
+    base_class : type
+        Unidentifiable type that raised the exception.
+
+    """
+
+    def __init__(self, base_class: type):
+        super().__init__(
+            message=f'unidentifiable base class: {repr(base_class.__name__)}'
+        )

tests/factory/test_subclass_factory.py

@@ -9,7 +9,9 @@
 from pytest import fixture, raises
 
 from design_pytterns.factory import SubclassFactory
-from design_pytterns.errors import UnregisteredClassIdError
+from design_pytterns.errors import (
+    UnidentifiableSubclassError, UnregisteredClassIdError
+)
 from design_pytterns.interfaces import SubclassIdentifiable
 
 
@@ -85,7 +87,7 @@ class MyUnidentifiableBaseClass():
     class _UnidentifiableClass1(MyUnidentifiableBaseClass):
         pass
 
-    with raises(TypeError):
+    with raises(UnidentifiableSubclassError):
         SubclassFactory(MyUnidentifiableBaseClass)