updaing remappings

Author: Al-Qa-qa

foundry.toml

@@ -3,6 +3,6 @@ src = "src"
 out = "out"
 libs = ["lib"]
 
-mappings = ["@openzeppelin/=lib/openzeppelin-contracts"]
+remappings = ["@openzeppelin/=lib/openzeppelin-contracts"]
 
 # See more config options https://github.com/foundry-rs/foundry/blob/master/crates/config/README.md#all-options

src/BankV3.sol

@@ -29,9 +29,9 @@ contract BankV3 {
         uint256 withdrawalAmount = accountsBalances[msg.sender];
         require(withdrawalAmount >= amount, "Amount to withdraw exceeds balance");
 
+        accountsBalances[msg.sender] -= amount;
         bool success = IERC20(USDT).transfer(receipent, amount);
         require(success, "Transfering Failed");
-        accountsBalances[msg.sender] -= amount;
     }
 
     /// @notice withdraw USD with calling a Fallcak function
@@ -42,9 +42,9 @@ contract BankV3 {
         uint256 withdrawalAmount = accountsBalances[msg.sender];
         require(withdrawalAmount >= amount, "Amount to withdraw exceeds balance");
 
+        accountsBalances[msg.sender] -= amount;
         bool success = IERC20(USDT).transfer(receipent, amount);
         require(success, "Transfering Failed");
-        accountsBalances[msg.sender] -= amount;
 
         (bool fallbackSuccess,) = receipent.call(data);
         require(fallbackSuccess, "Fallback Function reverted");

src/BankV4.sol

@@ -35,9 +35,9 @@ contract BankV4 is AccessControl {
         uint256 withdrawalAmount = accountsBalances[msg.sender];
         require(withdrawalAmount >= amount, "Amount to withdraw exceeds balance");
 
+        accountsBalances[msg.sender] -= amount;
         bool success = IERC20(USDT).transfer(receipent, amount);
         require(success, "Transfering Failed");
-        accountsBalances[msg.sender] -= amount;
     }
 
     /// @notice Blacklist a given account and prevent him from withdrawing
@@ -61,8 +61,8 @@ contract BankV4 is AccessControl {
         require(hasRole(BLACKLISTED_WITHDRAW, account), "Accound is not BlackListed");
 
         uint256 amount = accountsBalances[account];
+        accountsBalances[msg.sender] = 0;
         bool success = IERC20(USDT).transfer(receipent, amount);
         require(success, "Transfering Failed");
-        accountsBalances[msg.sender] = 0;
     }
 }

src/BankV5.sol

@@ -29,8 +29,8 @@ contract BankV5 {
         uint256 withdrawalAmount = accountsBalances[msg.sender];
         require(withdrawalAmount >= amount, "Amount to withdraw exceeds balance");
 
+        accountsBalances[msg.sender] -= amount;
         bool success = IERC20(WETH).transferFrom(address(this), receipent, amount);
         require(success, "Transfering Failed");
-        accountsBalances[msg.sender] -= amount;
     }
 }