Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

font improvements #27

Open
trend-1 opened this issue Apr 8, 2023 · 17 comments
Open

font improvements #27

trend-1 opened this issue Apr 8, 2023 · 17 comments
Labels
enhancement New feature or request

Comments

@trend-1
Copy link

trend-1 commented Apr 8, 2023

Great little app you got, thanks.

Some improvements could be made to the ui.

  • the gray colour of the cloud overcast % is almost imperceptible while the dark theme is active
  • the yellow colour of the UV intensity is imperceptible while the light theme is active
  • it would be nice to be able to choose a larger font because on smaller devices it is a bit hard to read
@LinuxinaBit
Copy link

This could mostly be summed up to "Enlarge the icons and make the text brighter".
Maybe that could be achieved in a similar way to my concept for #7 but in the daily weather list...

@farfromrefug
Copy link
Collaborator

@trend-1 @RageGamerBoi i am working on a "font scale" setting so that you can adjust to your liking.
As for the colors i will look at it

@trend-1
Copy link
Author

trend-1 commented Apr 20, 2023

@farfromrefug Sounds great !

Looking forward to it.

@farfromrefug
Copy link
Collaborator

@trend-1 @RageGamerBoi new release coming really soon with basic font scale setting available through the app bottom sheet menu. Let me know what you think

@LinuxinaBit
Copy link

LinuxinaBit commented Apr 20, 2023

Oh, wow, it works really well!
Everything moves without too much overlapping, except past 1.7 on my device but that's really extreme.
There's also a bit of an overlap on the temperature and the high/low temperature readouts.
With a little polish it will be an amazing feature.
I like it a lot :)

@farfromrefug
Copy link
Collaborator

@RageGamerBoi could you share a screenshot of where it fails ?

@LinuxinaBit
Copy link

LinuxinaBit commented Apr 21, 2023

Before the font change it looked as you would expect.
Regular resolution:

Screenshot_20230421-074103-074

1.6x Scale:

Screenshot_20230421-074036-007

Would limiting font size for each component fix the problem?

@farfromrefug
Copy link
Collaborator

@RageGamerBoi thanks! i cant do much about the ones with "updated" and daily icons overlapping temperature. But i should have fixed the first one in the next release

@LinuxinaBit
Copy link

Great! 👍

@farfromrefug
Copy link
Collaborator

@RageGamerBoi btw i am also thinking about resizing daily items height based on font scale (like it is done in hourly view). What do you think?

@LinuxinaBit
Copy link

LinuxinaBit commented Apr 21, 2023

That sounds good.
It would make larger text a little less cramped.

@trend-1
Copy link
Author

trend-1 commented Apr 21, 2023

Font sizes above 1.7 are starting to overlap, especially the larger day fonts (date, short description and temperature).

Also cloud coverage with a lower percentage (e.g. 26%) is almost imperceptible in both light and dark themes. (Just to give @farfromrefug a bit more specific info regarding this color topic.)

Otherwise good implementation. Nicely done 👍

@farfromrefug
Copy link
Collaborator

@trend-1 i made cloud colors a bit more visible but it is intended to be much less visible if there is almost no cloud.
I fixed colors i think ;)
As for the max font scale yes it will fail at a certain scale. I could block it at a certain level but then people with big phones would be blocked when for them it would not overlap

@trend-1
Copy link
Author

trend-1 commented Apr 21, 2023

Max font scale:

  • I understand
  • Just wanted to let you know my "test results"
  • Works for me!

Colors:

  • I understand the philosophy
  • Perhaps you could opt for better readable text
    • What's the use of giving information if not visible?

@farfromrefug
Copy link
Collaborator

@RageGamerBoi my idea about cloud color is that i dont want my attention to get onto cloud icon and cover % if there is no (or almost no) clouds. Most of the time i tend to not read data and rely on colors/icons

@trend-1
Copy link
Author

trend-1 commented Apr 21, 2023

@farfromrefug I understand the philosophy.

  • This could be interesting information to others
  • It would make more sense imo to make use of a threshold
    • that way the "fading effect" is still present (demanding less attention)
    • the information is still visible to those who need it

@LinuxinaBit
Copy link

LinuxinaBit commented Apr 21, 2023

@trend-1 @farfromrefug What about having the text's minimum transparency be 50%, while the icon can still go to 100% hidden?

@farfromrefug farfromrefug added the enhancement New feature or request label Jan 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants