Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Map animation is a touch too fast #227

Open
Mrnofish opened this issue Sep 28, 2024 · 8 comments
Open

Map animation is a touch too fast #227

Mrnofish opened this issue Sep 28, 2024 · 8 comments

Comments

@Mrnofish
Copy link

Mrnofish commented Sep 28, 2024

The map animation is a touch fast for my tastes, it makes interpreting the movement of the rain cells harder than it needs be. Would it be possible to perhaps add some way to customize the speed?

@farfromrefug
Copy link
Collaborator

@Mrnofish sure i ll make it configurable!

@farfromrefug
Copy link
Collaborator

farfromrefug commented Oct 24, 2024

@Mrnofish it is now implemented

@cb8121
Copy link

cb8121 commented Oct 29, 2024

Hi, after the Implementation in v2.8.1 the map isn't working any more.
Screenshot_20241029_104134_OSS Weather

@farfromrefug
Copy link
Collaborator

@cb8121 really sorry. Will fix it

@Mrnofish
Copy link
Author

Mrnofish commented Oct 30, 2024

FWIW it's working for me. There is some room for small improvements (e.g. the slider setting a delay value instead of a speed? thus apparently working the opposite that one would expect) but it's fine otherwise, thanks for taking care of it.

(I'm leaving this open since it's being used to track the regression.)

@farfromrefug
Copy link
Collaborator

@Mrnofish indeed the animation speed is defined by a delay. Would it be better to have a speed like with default to 1 and the going slower (0.5) or faster (1.5) ?

@Mrnofish
Copy link
Author

Since the proposed scale would be completely arbitrary (real time not being a useful option), it would come down to the tuning.

What I was pointing out, is that a slider labeled "speed" intuitively associates bigger numbers to higher speeds, whereas now it works in reverse (in fact sliding to the right, which is generally associated with higher/louder/faster/etc, causes the animation to slow down instead.)

I can certainly live with the way it is, though, and simply renaming the slider so that it's consistent with its function would probably be okay for most.

@farfromrefug
Copy link
Collaborator

@Mrnofish yes i agree it is not ok as it is. I will change it to some arbitrary "speed factor" (1 being the default)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants