Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Does not fetch signatures when installed clientside on Quilt #423

Open
NoSadBeHappy opened this issue Aug 9, 2023 · 26 comments
Open

Does not fetch signatures when installed clientside on Quilt #423

NoSadBeHappy opened this issue Aug 9, 2023 · 26 comments
Assignees
Labels
3rd party issue The issue is not related to this mod alone bug Something isn't working confirmed Confirmed bug/approved suggestion

Comments

@NoSadBeHappy
Copy link

NoSadBeHappy commented Aug 9, 2023

Modloader

Quilt

Minecraft Version

1.20.1

Modloader Version

0.19.2

No Chat Reports Version

1.20.1-v2.2.2

Modpack Info

https://modrinth.com/modpack/sodiumplus

The latest.log File

https://gist.github.com/NoSadBeHappy/43ea1b31f6fe58ce50e9578158ad7eab

Bug Description

When chatting in my server, the server kicks me even if I have it set to allow chat reports.

Steps to Reproduce

  1. join any server
  2. set no chat reports to always, meaning it allows chat reporting
  3. say something in chat
  4. get kicked

Other Information

  • enforce-secure-profile is set to false on the server.
  • the server also has liberated chat plugin installed, but the same issue occures without the plugin.
  • image
  • Here are all of the plugins on the server.
  • I can chat without no chat reports but with all other mods.
  • My server is a purper server if that helps.
  • ideally, I also would like to allow people to use no chat reports, and not get kicked for sending messages without chat reports as well.
@NoSadBeHappy NoSadBeHappy added the bug Something isn't working label Aug 9, 2023
@Madis0

This comment was marked as outdated.

@NoSadBeHappy

This comment was marked as outdated.

@Madis0

This comment was marked as outdated.

@NoSadBeHappy

This comment was marked as outdated.

@Madis0
Copy link
Collaborator

Madis0 commented Aug 10, 2023

Then I'd assume it is caused by EssentialsXChat, try disabling that.

@Aizistral
Copy link
Member

Then I'd assume it is caused by EssentialsXChat, try disabling that.

Let me reassure you that I am not unwilling to fix plugin compatibility issues, and in fact, I have done so in the past. However, I require a conclusive report that specifies exactly which plugin causes the issue and under what circurmstances, so that I may reproduce it myself and figure out what action would be appropriate on our side regarding this, if any.
@NoSadBeHappy, I ask you to isolate the issue to the extent of your ability and specify every single relevant detail pertaining to it, so that I may aid in its long-term resolution.

@Aizistral Aizistral reopened this Aug 10, 2023
@Aizistral
Copy link
Member

Sorry for accidental closure, misclicked.

@NoSadBeHappy
Copy link
Author

NoSadBeHappy commented Aug 10, 2023

I don't think this is because of essentialsx chat. I have tried on a different server, and I have the same problem. As you can see in my server.properties, enforce-secure-profile is off, and here are my plugins,
image
and I still have the same issue. When adding liberated-chat, I still have the same issue no matter what mode no-chat-reports is on. Due to this, I believe that my issue is most likely due to other mods I have, so I have sent all of my config, logs, crash-reports, and mods folders inside my .minecraft folder below. This is mostly sodium plus, as I said in the og issue, but I have added a couple of mods to it. (yes im aware I should have sensored my ip adress.) I am happy to supply any extra information to help you get this resolved, and thank you very much for your help.

.minecraft.zip
https://drive.google.com/file/d/1AL3oglOEkmBa0nNwUi4LgUV_9NjJsspW/view?usp=sharing

@Madis0

This comment was marked as outdated.

@IlyaYezelovsky
Copy link
Contributor

I think you should replace LiberatedChat with FreedomChat. My server also uses EssentialsXChat (and FreedomChat), but this issue did not occur. In addition, I am using the Forge 1.20.1 client and the server is Leaves.
And, why you use Minecraft 1.19.1 with NCR 1.20.1?

@NoSadBeHappy
Copy link
Author

The reason I think it is my client is because it kicks even when I allow no chat reports to send reports. I will try freedomchat though.

@NoSadBeHappy

This comment was marked as outdated.

@IlyaYezelovsky

This comment was marked as outdated.

@NoSadBeHappy

This comment was marked as outdated.

@Madis0 Madis0 added the information needed Awaiting additional information label Sep 9, 2023
@Madis0 Madis0 removed the information needed Awaiting additional information label Sep 10, 2023
@RedstoneWizard08
Copy link

RedstoneWizard08 commented Sep 11, 2023

Shouldn't this work with vanilla servers, though? It used to auto-disable, and this is an issue with Sodium Plus (the client), not the server. The server config shouldn't matter. Has this been tested on vanilla servers? The same thing happened to me.

@Madis0
Copy link
Collaborator

Madis0 commented Sep 11, 2023

By the symptoms, this may be an issue with the way NCR interacts with the Quilt client, so the signatures may not be fetched in the first place. Aizistral has said he'll have a look at it.

@jan-Sanku
Copy link

I'm having this issue as well.

By the symptoms, this may be an issue with the way NCR interacts with the Quilt client, so the signatures may not be fetched in the first place. Aizistral has said he'll have a look at it.

Indeed, I was kicked off vanilla servers with enforce-secure-profile=false using NCR on Quilt, regardless of NCR settings. Switched to Fabric and it works even with signatures forced on. I hope that's useful in some way.

@CompeyDev
Copy link

Facing the same issue on my client while using the Quilt loader all the time. Can confirm.

@CompeyDev

This comment was marked as duplicate.

@NoSadBeHappy

This comment was marked as duplicate.

@CompeyDev

This comment was marked as duplicate.

@RedstoneWizard08

This comment was marked as off-topic.

@jan-Sanku
Copy link

I feel like new versions of NCR should not be tagged as compatible with Quilt on Modrinth until this is fixed, because it's currently not really usable on Quilt.

@Madis0
Copy link
Collaborator

Madis0 commented Feb 12, 2024

Per request, 1.20+ versions no longer have the Quilt marking. If you can reproduce it in earlier versions, let us know.

@Madis0 Madis0 changed the title Server kicks when chatting using NoChatReports, even when set to allow reports. Does not fetch signatures when installed clientside on Quilt Feb 12, 2024
@CompeyDev
Copy link

Temporarily, that works, but it would be better to have this issue sorted out in the future. Been using fabric for a couple months instead of quilt which isn't ideal, since there's some mods I simply cannot use.

@Aizistral Aizistral added confirmed Confirmed bug/approved suggestion 3rd party issue The issue is not related to this mod alone labels Apr 17, 2024
@jan-Sanku
Copy link

any updates on this one? i see this has the "3rd party" label now, is there anyone in particular this needs to be reported to?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3rd party issue The issue is not related to this mod alone bug Something isn't working confirmed Confirmed bug/approved suggestion
Projects
None yet
Development

No branches or pull requests

7 participants