Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport to 1.19.2 #401

Open
itsdinkd opened this issue May 21, 2023 · 4 comments
Open

Backport to 1.19.2 #401

itsdinkd opened this issue May 21, 2023 · 4 comments
Assignees
Labels
enhancement New feature or request information needed Awaiting additional information

Comments

@itsdinkd
Copy link

itsdinkd commented May 21, 2023

Idea

You have fixed tons of issues with NoChatreports on mc 1.19.3, and 1.19.4

However, majority of your userbase is still on 1.19.2 (Due to all major modpacks being on 1.19.2 and not the other .3 and .4 versions, except for "optimization client side modpacks").

Please backport 2.X to 1.19.2 Fabric.

See downloads

Notice 1.19.2 with 51k, and all the other versions for higher MC versions do not come close.
image

2.5m for 1.19.2 all higher versions do not come close. Most of your users are on 1.19.2
image

@itsdinkd itsdinkd added the enhancement New feature or request label May 21, 2023
@Madis0
Copy link
Collaborator

Madis0 commented May 22, 2023

Keep in mind that chat signing on 1.19.2 works very differently from 1.19.3 and up, so not everything can be ported or it wouldn't make sense to do so in the same way. Maybe you should be more specific on what features would you even like a backport for?

@Aizistral
Copy link
Member

Aizistral commented May 22, 2023

I am aware that most of the users are still on 1.19.2. In fact, it seems that final 1.19.2 releases constitute the majority of mod's total downloads at this time. Due to this I am willing to make an exception and make a few updates for 1.19.2.

But as @Madis0 correctly stated, chat signing works very differently from 1.19.3 and onward, so most bugfixes and feature updates simply cannot be backported as is. I am open for suggestions on what should be backported and how.

@IlyaYezelovsky
Copy link
Contributor

IlyaYezelovsky commented May 24, 2023

It seems like a good idea, but I always use Forge :)

@Aizistral
Copy link
Member

Aizistral commented May 24, 2023

It seems like a good idea, but I always use Forge :)

Yeah, this would definitely not be specific to Fabric if I ever do it.

@Aizistral Aizistral changed the title Backport to 1.19.2 Fabric Backport to 1.19.2 May 24, 2023
@Madis0 Madis0 added the information needed Awaiting additional information label Sep 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request information needed Awaiting additional information
Projects
None yet
Development

No branches or pull requests

4 participants