Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hotkeys #381

Open
4 tasks
Madis0 opened this issue Mar 23, 2023 · 6 comments
Open
4 tasks

Hotkeys #381

Madis0 opened this issue Mar 23, 2023 · 6 comments
Assignees
Labels
confirmed Confirmed bug/approved suggestion enhancement New feature or request

Comments

@Madis0
Copy link
Collaborator

Madis0 commented Mar 23, 2023

Idea

NCR could have a set of hotkeys for people to bind. None of those should be set to a key by default to prevent accidents/confusion.

Reasoning

Accessibility and convenience

Other Information

  • Encryption toggle
  • Encryption config
  • Chat state toggle
  • Global config

Toggles should show an actionbar text indicating current value when pressed.

@Madis0 Madis0 added the enhancement New feature or request label Mar 23, 2023
@Aizistral Aizistral added the confirmed Confirmed bug/approved suggestion label May 17, 2023
@Aizistral
Copy link
Member

I like all of these except global config, it feels like that would be better done with a GUI button. In principle we could extend the functionality of config reload button in multiplayer menu to allow access to actual config screen with, say, right-click, and simple reload with left-click. Obviously the screen still depends on Cloth Config API to work, so it won't be accessible in any way without it.

@Aizistral
Copy link
Member

Aizistral commented May 17, 2023

I like all of these except global config, it feels like that would be better done with a GUI button.

I think that is exactly what #349 suggests, just with a safety status button instead of the one in multiplayer menu. Not sure which one would work better.

@Madis0
Copy link
Collaborator Author

Madis0 commented May 17, 2023

I agree that #349 should be implemented and I agree that it should be implemented in the status icon, as that is contextual.
Implementing it in the refresh icon seems unnecessary as the user can

  • use Mod Menu
  • edit the config file (which is what the refresh button is for) or
  • even have an additional button for config alone as the screen space is not limited, nor do buttons obstruct anything in the server screen

@Madis0
Copy link
Collaborator Author

Madis0 commented May 17, 2023

Either way implementing a hotkey to config as well would be similar to minimap mods for example, where people may want to edit their config often. I personally don't think I'd need it either, it was just suggested to "complete the set".

@Secret-chest
Copy link
Contributor

Please disable them by default!

@IlyaYezelovsky
Copy link
Contributor

Please disable them by default!

Why?

It is best to set it in the vanilla key settings.

@Madis0 Madis0 mentioned this issue Jan 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
confirmed Confirmed bug/approved suggestion enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

4 participants