Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

"Confirm twice" #253

Open
Madis0 opened this issue Oct 31, 2022 · 1 comment
Open

"Confirm twice" #253

Madis0 opened this issue Oct 31, 2022 · 1 comment
Assignees
@Aizistral
Labels
confirmed Confirmed bug/approved suggestion enhancement New feature or request

Comments

@Madis0
Copy link
Collaborator

Madis0 commented Oct 31, 2022 •
edited
Loading

Idea

NCR could have a "confirm twice" option, described as

If the server requires signing, every chat message needs two Enter keypresses to be sent.

Reasoning

Just like it provided a privacy protection to chat preview, it would provide some "think twice"-esque protection for chat signing. This would not apply for commands that don't require signing (if possible to determine).

Other Information

The code could be directly taken from 1.19.2 chat preview's "when sending" option, even though chat preview itself was removed with 1.19.3.
@Madis0 Madis0 added the enhancement New feature or request label Oct 31, 2022
@Aizistral Aizistral mentioned this issue Nov 4, 2022
Closed
@Aizistral Aizistral added confirmed Confirmed bug/approved suggestion priority: normal labels Nov 4, 2022
@Aizistral Aizistral mentioned this issue Dec 4, 2022
Merged
@Madis0 Madis0 changed the title "Confirm twice" for 1.19.3 "Confirm twice" May 5, 2023
@IlyaYezelovsky
Copy link
Contributor

It's my personal idea that it is disabled by default.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Aizistral Aizistral

Labels
confirmed Confirmed bug/approved suggestion enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@Madis0 @Aizistral @IlyaYezelovsky