Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Enhancement] Add a configuration option to always send secure profile key to whitelisted servers (in other words, to always treat whitelisted servers as enforcing secure profile) #184

Closed
akemin-dayo opened this issue Sep 2, 2022 · 4 comments
Assignees
Labels
confirmed Confirmed bug/approved suggestion enhancement New feature or request

Comments

@akemin-dayo
Copy link

akemin-dayo commented Sep 2, 2022

It would be helpful to add an configuration option to always send the user's secure profile key to any whitelisted server — in other words, to always treat whitelisted servers as enforcing secure profile.

This would avoid an undesirable situation where a user must prevent NCR from being loaded by their modloader of choice in order to join a secure-profile-enforced server that NCR is failing to detect (perhaps due to a custom disconnect reason being sent by the server), as seen in #185.

@akemin-dayo akemin-dayo added the enhancement New feature or request label Sep 2, 2022
@akemin-dayo

This comment was marked as resolved.

@Aizistral

This comment was marked as resolved.

@akemin-dayo akemin-dayo changed the title [Enhancement] Add a configuration option to always send secure profile key to whitelisted servers (in other words, to always treat whitelisted servers as enforcing secure profile) / [Issue] NCR can sometimes fail to detect that a third-party server is enforcing secure profile [Enhancement] Add a configuration option to always send secure profile key to whitelisted servers (in other words, to always treat whitelisted servers as enforcing secure profile) Sep 2, 2022
@akemin-dayo

This comment was marked as resolved.

@Madis0
Copy link
Collaborator

Madis0 commented May 18, 2023

This was solved with the introduction of signing modes in the 1.19.3 version of NCR.

@Madis0 Madis0 closed this as completed May 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
confirmed Confirmed bug/approved suggestion enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants