#1-4Task. Dzmitry.ais #42
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
IlyaMokin
reviewed
Jul 1, 2020
task/01-strings-tasks.js
Outdated
|
|
||
| rec += '\n'; | ||
| } |
There was a problem hiding this comment.
Acceptable, but can be done easier with string.repeat
task/03-date-tasks.js
Outdated
| timeSpanToString: timeSpanToString, | ||
| angleBetweenClockHands: angleBetweenClockHands | ||
| parseDataFromRfc2822: parseDataFromRfc2822, | ||
| parseDataFromIso8601: parseDataFromIso8601, |
There was a problem hiding this comment.
the PR has a lot of redundant changes in styling, spaces, comments....
Please follow simple rules:
- do not add any non logic changes to code if review is required
- if the changes in styling are important - you can do it as separate PR with styling only changes to avoid noise in the main PR
There was a problem hiding this comment.
Thank you for the review. Can it be problem with prettier plugin in VScode? Because i didn't change anything except deleting throw new Error and writing code.
There was a problem hiding this comment.
Yes, I guess that autoformat of IDE, but you will be facing with that in future in your projects so that do change that you need to understand how to avoid it =)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Task 1-4
https://travis-ci.org/github/marioti95/js-assignments