Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CI fails on dapps broken by #8599 #8648

Open
mhofman opened this issue Dec 11, 2023 · 2 comments · May be fixed by Agoric/testnet-load-generator#114
Open

CI fails on dapps broken by #8599 #8648

mhofman opened this issue Dec 11, 2023 · 2 comments · May be fixed by Agoric/testnet-load-generator#114
Assignees
@mhofman
Labels
bug Something isn't working technical-debt tooling repo-wide infrastructure

Comments

@mhofman
Copy link
Member

mhofman commented Dec 11, 2023 •
edited
Loading

Describe the bug

CI fails with the Symbol errors because they directly or transitively depend on an old "ses" without the fix. This is the same as #8599 but for dapps.

To Reproduce

Example https://github.com/Agoric/agoric-sdk/actions/runs/7172022723/job/19528797470?pr=8634

Expected behavior

CI passes

Additional context

In this case bumping the endo/ses deps should be acceptable, to the amount that the dapps are not incompatible.
@mhofman mhofman added bug Something isn't working tooling repo-wide infrastructure labels Dec 11, 2023
@mhofman mhofman self-assigned this Dec 11, 2023
@mhofman mhofman linked a pull request Dec 11, 2023 that will close this issue
Open
@ivanlei
Copy link
Contributor

ivanlei commented Jan 8, 2024

Does not repro consistently

@mhofman
Copy link
Member Author

mhofman commented Jan 8, 2024

More precisely, this is currently worked around for the deployment-test (loadgen) by forcing using an image using node 18.18.

@turadg turadg mentioned this issue Apr 6, 2024
Draft
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mhofman mhofman

Labels
bug Something isn't working technical-debt tooling repo-wide infrastructure
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

update deps to match latest agoric-sdk Agoric/testnet-load-generator
3 participants
@turadg @mhofman @ivanlei