Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increase history length of flight recorder #8425

Open
mhofman opened this issue Oct 3, 2023 · 2 comments
Open

Increase history length of flight recorder #8425

mhofman opened this issue Oct 3, 2023 · 2 comments
Assignees
Labels
cosmic-swingset package: cosmic-swingset enhancement New feature or request good first issue Good for newcomers telemetry

Comments

@mhofman
Copy link
Member

mhofman commented Oct 3, 2023

What is the Problem Being Solved?

The flight recorder is very useful to gather diagnostics from validators experiencing certain type of issues (e.g. AppHash failures), however because it's a ring buffer of limited size, we can quickly lose useful context. In particular during a restart, vats are replayed, which generate a lot of slog output that completely fills up the ring buffer.

During the debugging of #8423, we also noticed that the slog extracted from the flight recorder was much smaller than the capacity.

Description of the Design

A simple change would be to increase the circularBufferSize option. While this is technically a configurable option, no-one actually sets it in code, and it doesn't use an environment variable for configuration like other slog sender config. The current default value is 100 MB.

Security Considerations

None

Scaling Considerations

None

Test Plan

update the frcat tool and manually test

Upgrade Considerations

None

@mhofman mhofman added enhancement New feature or request cosmic-swingset package: cosmic-swingset telemetry labels Oct 3, 2023
@mhofman mhofman self-assigned this Oct 3, 2023
@mhofman
Copy link
Member Author

mhofman commented Oct 3, 2023

This would have potentially helped diagnose #8423 further if we could have read the previous run's slogs.

@ivanlei
Copy link
Contributor

ivanlei commented Jan 2, 2024

Could potentially clobber flight recorder on startup and avoid complexity of increasing flight recorder size.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cosmic-swingset package: cosmic-swingset enhancement New feature or request good first issue Good for newcomers telemetry
Projects
None yet
Development

No branches or pull requests

3 participants