Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[requirement] smart wallets retain non-Cosmos assets through bulldozer upgrade #6131

Closed
turadg opened this issue Sep 4, 2022 · 2 comments
Closed
Labels
contract-upgrade enhancement New feature or request vaults_triage DO NOT USE wontfix This will not be worked on

Comments

@turadg
Copy link
Member

turadg commented Sep 4, 2022

What is the Problem Being Solved?

The plan for #6099 is to blow away and recreate the wallet contract. That requires that all assets to be held held at the Cosmos level so they can be re-associated with the JS purses.

Invitations and liquidity tokens, two essential assets in the Inter economy are not held at the Cosmos level and would be blown away by the upgrade mechanism in 6099. After PSM launch we need to support retention of these assets.

Description of the Design

TBD

Security Considerations

Test Plan

@turadg turadg added enhancement New feature or request contract-upgrade labels Sep 4, 2022
@Tartuffo Tartuffo added this to the Mainnet 1 RC0 milestone Sep 4, 2022
@Tartuffo Tartuffo removed this from the Mainnet 1 RC0 milestone Sep 21, 2022
@ivanlei ivanlei added the vaults_triage DO NOT USE label Dec 20, 2022
@dckc dckc changed the title [requirement] smart wallets retain non-Cosmos assets through upgrade [requirement] smart wallets retain non-Cosmos assets through bulldozer upgrade Jan 27, 2023
@dckc
Copy link
Member

dckc commented Jan 27, 2023

I see 2 kinds of non-cosmos assets to preserve:

invitations

Seems straightforward to just resend invitations to the EC.

smart wallet purchase price (10 BLD)

We have the list of accounts that have paid:
agd --node https://main.rpc.agoric.net:443 query vstorage children published.wallet

chainStorage read is tricky

I thought it would be straightforward to add a read method to chainStorage, but in discussion with @warner I learned it's very much against the grain of an architectural direction for SwingSet. So whatever we want to read from chainStorage, we might want to do so in the go code that boots the JS world.

@ivanlei ivanlei added this to the Vaults RC0 milestone Feb 1, 2023
@dckc dckc added the wontfix This will not be worked on label Feb 1, 2023
@dckc
Copy link
Member

dckc commented Feb 1, 2023

only non-cosmos things are invitations, which we can re-issue in the bulldozer upgrade

@dckc dckc closed this as completed Feb 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
contract-upgrade enhancement New feature or request vaults_triage DO NOT USE wontfix This will not be worked on
Projects
None yet
Development

No branches or pull requests

4 participants