Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make vat-network upgradable #5696

Closed
5 tasks done
Tracked by #8903
warner opened this issue Jun 30, 2022 · 6 comments · Fixed by #8721
Closed
5 tasks done
Tracked by #8903

make vat-network upgradable #5696

warner opened this issue Jun 30, 2022 · 6 comments · Fixed by #8721
Assignees
Labels
enhancement New feature or request SwingSet package: SwingSet vaults_triage DO NOT USE
Milestone

Comments

@warner
Copy link
Member

warner commented Jun 30, 2022

What is the Problem Being Solved?

As part of #5666 we need to make the "network vat" upgradable. This vat hosts a copy of
SwingSet/src/vats/network/router.js.

I'm not sure what this will entail (I'm not very familiar with this network code).

Description of the Design

This includes not only making the network vat durable, but also providing a utility for clients of the network vat (such as Pegasus or ICA) to tolerate an upgrade (and its broken promises) without losing precious state.

Security Considerations

Test Plan

Tasks

  1. enhancement
    michaelfig
  2. automerge:squash
  3. enhancement
    dckc
  4. 2 of 2
    enhancement needs-design
    iomekam
@warner warner added enhancement New feature or request SwingSet package: SwingSet labels Jun 30, 2022
@Tartuffo Tartuffo added this to the Mainnet 1 milestone Jul 19, 2022
@warner
Copy link
Member Author

warner commented Jul 19, 2022

@gibson042 could you take a look at this and see how feasible it seems?

@warner
Copy link
Member Author

warner commented Jul 28, 2022

@FUDCo walked through the packages/SwingSet/src/vats/network/ code today.. we're thinking that maybe it should be moved out of swingset, either into packages/vats/ that uses it, or into its own package.

His preliminary assessment is that making it upgradable wouldn't be too hard.

@FUDCo FUDCo self-assigned this Aug 1, 2022
@Tartuffo
Copy link
Contributor

Tartuffo commented Aug 4, 2022

@FUDCo making you the primary on this.

@FUDCo
Copy link
Contributor

FUDCo commented Aug 4, 2022

I spoke with @michaelfig and he said that moving this to packages/vats was reasonable, since it isn't really managed like the other vats that are part of SwingSet but is more of an IBC thing. Apparently the primary reason this got put into packages/SwingSet was that packages/vats didn't exist at the time.

@warner
Copy link
Member Author

warner commented Aug 19, 2022

break this into two pieces:

We can defer the upgrade testing for after the pso milestone.

@dckc
Copy link
Member

dckc commented Jan 26, 2023

vat-network wasn't in the pismo vats. I think it's only needed for dyanimc IBC, which isn't a vaults release feature

cc @warner @michaelfig

@ivanlei ivanlei added this to the Vaults EVP milestone Feb 6, 2023
@michaelfig michaelfig removed this from the Vaults EVP milestone Feb 24, 2023
@ivanlei ivanlei removed the MUST-HAVE label Mar 20, 2023
@aj-agoric aj-agoric added this to the Calypso milestone Sep 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request SwingSet package: SwingSet vaults_triage DO NOT USE
Projects
None yet
Development

Successfully merging a pull request may close this issue.

9 participants