Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vault.makeTransferInvitation #4820

Closed
dtribble opened this issue Mar 10, 2022 · 0 comments · Fixed by #4844
Closed

vault.makeTransferInvitation #4820

dtribble opened this issue Mar 10, 2022 · 0 comments · Fixed by #4844
Assignees
Labels
enhancement New feature or request Vaults VaultFactor (née Treasury) Zoe package: Zoe
Milestone

Comments

@dtribble
Copy link
Member

dtribble commented Mar 10, 2022

What is the Problem Being Solved?

The transfer invitation must include details of the vault being transferred in order for it to have a legible value.

Description of the Design

Add (at least) the current debt and collateral in the invitation custom properties,

Security Considerations

For an invitation to be a usefully transferrable eright, the invitation's amount must contain enough reliable information for someone else to determine whether they would want an invitation with that amount.

This is invitation legibility (#4822), also known as "The Fred problem" and "The (invitation) pig-in-a-poke problem". It is this legibility that enables higher-order smart contract composition, where derived rights created by contracts to be treated like any other eright by other contracts. This is indeed the purpose of converting active vaults into their exclusively transferrable invitation form.

In general, for an eright to be meaningfully tradable, they must be assayable. For the trading of erights to be protected by Zoe offer safety, the amount used in a proposal's want must be adequate to describe the right desired such that any right that satisfies that want actually satisfied the desire it is supposed to represent.

The current invitation form of a vault has none of the information needed to evaluate whether one would want the right it represents. The call to zcf.makeInvitation should include customProperties to be included in the invitation's amount that will reliably provide the needed information.

Test Plan

Make a test that wants more than the invitation specifies and therefore rejects the reallocate.

@dtribble dtribble added the enhancement New feature or request label Mar 10, 2022
@Tartuffo Tartuffo added the Vaults VaultFactor (née Treasury) label Mar 14, 2022
@dtribble dtribble self-assigned this Mar 14, 2022
@dtribble dtribble added the Zoe package: Zoe label Mar 14, 2022
@Tartuffo Tartuffo added this to the Mainnet 1 milestone Mar 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request Vaults VaultFactor (née Treasury) Zoe package: Zoe
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants