Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PricedCallSpread should accept longCollateralShare in basis points #2282

Open
Chris-Hibbert opened this issue Jan 29, 2021 · 0 comments
Open
Labels
enhancement New feature or request good first issue Good for newcomers Zoe Contract Contracts within Zoe

Comments

@Chris-Hibbert
Copy link
Contributor

What is the Problem Being Solved?

makeInvitationPair() in the PricedCallSpread contract takes the longCollateralShare in basis points, and then multiplies that by 100 to construct a percentMath in basis points for better precision. The caller should be able to provide 4 digits of accuracy, rather than just the two currently allowed.

Description of the Design

Change the name (e.g. to makeInvitations()) and deprecate makeInvitationPair().

Security Considerations

None

Test Plan

Add a test to show that the basis points value is handled.

@Chris-Hibbert Chris-Hibbert added enhancement New feature or request good first issue Good for newcomers Small Zoe Contract Contracts within Zoe labels Jan 29, 2021
@Chris-Hibbert Chris-Hibbert added this to the Beta Launch milestone Jan 29, 2021
@katelynsills katelynsills removed the Beta label Feb 17, 2021
@katelynsills katelynsills removed this from the Beta Launch milestone Feb 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers Zoe Contract Contracts within Zoe
Projects
None yet
Development

No branches or pull requests

3 participants