Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove unused rollup dependency from several packages #1223

Open
warner opened this issue Jun 27, 2020 · 6 comments
Open

remove unused rollup dependency from several packages #1223

warner opened this issue Jun 27, 2020 · 6 comments
Labels
good first issue Good for newcomers tooling repo-wide infrastructure

Comments

@warner
Copy link
Member

warner commented Jun 27, 2020

We have a leftover devDependency on rollup in several packages. I think I saw it in:

  • cosmic-swingset
  • eventual-send
  • swingset
  • transform-metering
  • acorn-eventual-send

We stopped creating bundles in yarn build steps recently, and I removed the package.json build steps which did that, but I think I missed some of the support machinery.

The task is to make sure we don't really need it anymore, and delete the lines from our package.json files.

@warner warner added good first issue Good for newcomers tooling repo-wide infrastructure labels Jun 27, 2020
@tonymade8
Copy link

singa

@tonymade8
Copy link

S.O.S

@tonymade8
Copy link

pp0ppp

@tonymade8
Copy link

2

We have a leftover devDependency on rollup in several packages. I think I saw it in:

  • cosmic-swingset
  • eventual-send
  • swingset
  • transform-metering
  • acorn-eventual-send

We stopped creating bundles in yarn build steps recently, and I removed the package.json build steps which did that, but I think I missed some of the support machinery.

The task is to make sure we don't really need it anymore, and delete the lines from our package.json files.

read soon

@tonymade8
Copy link

read out loud

@turadg
Copy link
Member

turadg commented Jul 5, 2023

@warner is there still work to do here? I see rollup is only in package.json of xsnap-lockdown, which I think you made recently.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers tooling repo-wide infrastructure
Projects
None yet
Development

No branches or pull requests

4 participants