Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: Agoric/agoric-sdk
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: @agoric/orchestration@0.2.0-u18.3
Choose a base ref
...
head repository: Agoric/agoric-sdk
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: @agoric/orchestration@0.2.0-u18.4
Choose a head ref
  • 17 commits
  • 61 files changed
  • 8 contributors

Commits on Dec 9, 2024

  1. chore(release): publish upgrade-18-rc3 (#10656)

    ## Description
    
    Created as per MAINTAINERS.md
    
    ## Changes
    
     - @agoric/cosmos@0.35.0-u18.3
     - agoric@0.22.0-u18.3
     - @agoric/benchmark@0.1.1-u18.3
     - @agoric/boot@0.2.0-u18.3
     - @agoric/builders@0.2.0-u18.3
     - @agoric/casting@0.4.3-u18.3
     - @agoric/cosmic-proto@0.5.0-u18.3
     - @agoric/cosmic-swingset@0.42.0-u18.3
     - @agoric/create-dapp@0.1.1-u18.3
     - @agoric/deploy-script-support@0.10.4-u18.3
     - fast-usdc@0.1.1-u18.3
     - @agoric/inter-protocol@0.17.0-u18.3
     - @agoric/orchestration@0.2.0-u18.3
     - @agoric/pegasus@0.8.0-u18.3
     - @agoric/smart-wallet@0.5.4-u18.3
     - @agoric/solo@0.11.0-u18.3
     - @agoric/swingset-runner@0.22.3-u18.3
     - @agoric/telemetry@0.6.3-u18.2
     - @agoric/vats@0.16.0-u18.3
     - @agoric/wallet-backend@0.15.0-u18.3
     
    ## Packages that have NEWS.md updates
    
    ```diff
    --- a/packages/telemetry/CHANGELOG.md
    +++ b/packages/telemetry/CHANGELOG.md
    @@ -3,6 +3,16 @@
     All notable changes to this project will be documented in this file.
     See [Conventional Commits](https://conventionalcommits.org) for commit guidelines.
     
    +### [0.6.3-u18.2](https://github.com/Agoric/agoric-sdk/compare/@agoric/telemetry@0.6.3-u18.1...@agoric/telemetry@0.6.3-u18.2) (2024-12-09)
    +
    +
    +### Bug Fixes
    +
    +* **telemetry:** Empty context persisted when remaining beans are negative after run finish ([#10635](#10635)) ([3988aa0](3988aa0))
    +* **telemetry:** event name typo ([070b154](070b154))
    +
    +
    +
     ### [0.6.3-u18.1](https://github.com/Agoric/agoric-sdk/compare/@agoric/telemetry@0.6.3-u18.0...@agoric/telemetry@0.6.3-u18.1) (2024-11-19)
     
     
    ```
    mujahidkay authored Dec 9, 2024
    Configuration menu
    Copy the full SHA
    6a4fdea View commit details
    Browse the repository at this point in the history

Commits on Dec 11, 2024

  1. fix(telemetry): timer-poll run.id (#10672)

    refs: #10357
    
    ## Description
    I did a bad copy paste in #10357, which causes the `run.id` of `timer-poll` triggers to all end up with the value `timer-poll-undefined`. Use the blockHeight instead.
    
    ### Security Considerations
    None
    
    ### Scaling Considerations
    None
    
    ### Documentation Considerations
    None
    
    ### Testing Considerations
    Not tested
    
    ### Upgrade Considerations
    Would be nice to pick in u18-rc4
    mhofman authored and mujahidkay committed Dec 11, 2024
    Configuration menu
    Copy the full SHA
    4185e77 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    14106da View commit details
    Browse the repository at this point in the history

Commits on Dec 13, 2024

  1. Configuration menu
    Copy the full SHA
    3b1a35d View commit details
    Browse the repository at this point in the history
  2. refactor: provideRetiredInstances

    turadg authored and mujahidkay committed Dec 13, 2024
    Configuration menu
    Copy the full SHA
    d07ff02 View commit details
    Browse the repository at this point in the history
  3. Record instances that will be replaced so we can manage them (#10680)

    closes: #10669
    
    ## Description
    
    Record instances of contracts that will be replaced so we can find them later and be able to manage them.
    
    ### Security Considerations
    
    We've lost the handle to some vats before, and it's a hassle.
    
    ### Scaling Considerations
    
    The problem gets worse as we upgrade more vats.
    
    ### Documentation Considerations
    
    None.
    
    ### Testing Considerations
    
    Verified that Auctions and Committee are present. The priceFeeds vary too much across test environments to be worth checking.
    
    ### Upgrade Considerations
    
    Yes..
    mergify[bot] authored and mujahidkay committed Dec 13, 2024
    Configuration menu
    Copy the full SHA
    d632323 View commit details
    Browse the repository at this point in the history
  4. chore: uprade 18 cherrypicks round 5 (#10676)

    ### Description
    
    Cherry-picks the following commits from master:
    - #10672
    (3b478fb)
    - #10668
    (a74161c)
    - #10680 (c883c39,
    1581127)
     
     No new upgrade name has been added. 
     
     Done partially via git cherry-pick and via the following rebase-todo:
     ```
    # PR #10680 Branch
    Record-instances-that-will-be-replaced-so-we-can-manage-them-10680-
    label
    base-Record-instances-that-will-be-replaced-so-we-can-manage-them-10680-
    pick c883c39 feat: record instances that will be replaced so we can
    manage them
    pick 1581127 refactor: provideRetiredInstances
    label
    pr-10680--Record-instances-that-will-be-replaced-so-we-can-manage-them-10680-
    reset
    base-Record-instances-that-will-be-replaced-so-we-can-manage-them-10680-
    merge -C d35659b
    pr-10680--Record-instances-that-will-be-replaced-so-we-can-manage-them-10680-
    # Record instances that will be replaced so we can manage them (#10680)
     ```
    mujahidkay authored Dec 13, 2024
    Configuration menu
    Copy the full SHA
    6cab101 View commit details
    Browse the repository at this point in the history
  5. chore(release): publish

     - agoric@0.22.0-u18.4
     - @agoric/benchmark@0.1.1-u18.4
     - @agoric/boot@0.2.0-u18.4
     - @agoric/builders@0.2.0-u18.4
     - @agoric/cosmic-swingset@0.42.0-u18.4
     - @agoric/create-dapp@0.1.1-u18.4
     - fast-usdc@0.1.1-u18.4
     - @agoric/inter-protocol@0.17.0-u18.4
     - @agoric/solo@0.11.0-u18.4
     - @agoric/swingset-runner@0.22.3-u18.4
     - @agoric/telemetry@0.6.3-u18.3
    mujahidkay committed Dec 13, 2024
    Configuration menu
    Copy the full SHA
    9770dee View commit details
    Browse the repository at this point in the history
  6. chore(release): publish upgrade-18-rc4 (#10693)

    ## Description
    
    Created as per instructions in MAINTAINERS.md
    
    ## Changes
    
     - agoric@0.22.0-u18.4
     - @agoric/benchmark@0.1.1-u18.4
     - @agoric/boot@0.2.0-u18.4
     - @agoric/builders@0.2.0-u18.4
     - @agoric/cosmic-swingset@0.42.0-u18.4
     - @agoric/create-dapp@0.1.1-u18.4
     - fast-usdc@0.1.1-u18.4
     - @agoric/inter-protocol@0.17.0-u18.4
     - @agoric/solo@0.11.0-u18.4
     - @agoric/swingset-runner@0.22.3-u18.4
     - @agoric/telemetry@0.6.3-u18.3
    
    ## Packages that have NEWS.md updates
    
    ```diff
    --- a/packages/boot/CHANGELOG.md
    +++ b/packages/boot/CHANGELOG.md
    @@ -3,6 +3,15 @@
     All notable changes to this project will be documented in this file.
     See [Conventional Commits](https://conventionalcommits.org) for commit guidelines.
     
    +## [0.2.0-u18.4](https://github.com/Agoric/agoric-sdk/compare/@agoric/boot@0.2.0-u18.3...@agoric/boot@0.2.0-u18.4) (2024-12-13)
    +
    +
    +### Features
    +
    +* record instances that will be replaced so we can manage them ([3b1a35d](3b1a35d))
    +
    +
    +
     ## [0.2.0-u18.3](https://github.com/Agoric/agoric-sdk/compare/@agoric/boot@0.2.0-u18.2...@agoric/boot@0.2.0-u18.3) (2024-12-09)
     
     **Note:** Version bump only for package @agoric/boot
    --- a/packages/builders/CHANGELOG.md
    +++ b/packages/builders/CHANGELOG.md
    @@ -3,6 +3,15 @@
     All notable changes to this project will be documented in this file.
     See [Conventional Commits](https://conventionalcommits.org) for commit guidelines.
     
    +## [0.2.0-u18.4](https://github.com/Agoric/agoric-sdk/compare/@agoric/builders@0.2.0-u18.3...@agoric/builders@0.2.0-u18.4) (2024-12-13)
    +
    +
    +### Features
    +
    +* record instances that will be replaced so we can manage them ([3b1a35d](3b1a35d))
    +
    +
    +
     ## [0.2.0-u18.3](https://github.com/Agoric/agoric-sdk/compare/@agoric/builders@0.2.0-u18.2...@agoric/builders@0.2.0-u18.3) (2024-12-09)
     
     **Note:** Version bump only for package @agoric/builders
    --- a/packages/inter-protocol/CHANGELOG.md
    +++ b/packages/inter-protocol/CHANGELOG.md
    @@ -3,6 +3,15 @@
     All notable changes to this project will be documented in this file.
     See [Conventional Commits](https://conventionalcommits.org) for commit guidelines.
     
    +## [0.17.0-u18.4](https://github.com/Agoric/agoric-sdk/compare/@agoric/inter-protocol@0.17.0-u18.3...@agoric/inter-protocol@0.17.0-u18.4) (2024-12-13)
    +
    +
    +### Features
    +
    +* record instances that will be replaced so we can manage them ([3b1a35d](3b1a35d))
    +
    +
    +
     ## [0.17.0-u18.3](https://github.com/Agoric/agoric-sdk/compare/@agoric/inter-protocol@0.17.0-u18.2...@agoric/inter-protocol@0.17.0-u18.3) (2024-12-09)
     
     **Note:** Version bump only for package @agoric/inter-protocol
    --- a/packages/telemetry/CHANGELOG.md
    +++ b/packages/telemetry/CHANGELOG.md
    @@ -3,6 +3,15 @@
     All notable changes to this project will be documented in this file.
     See [Conventional Commits](https://conventionalcommits.org) for commit guidelines.
     
    +### [0.6.3-u18.3](https://github.com/Agoric/agoric-sdk/compare/@agoric/telemetry@0.6.3-u18.2...@agoric/telemetry@0.6.3-u18.3) (2024-12-13)
    +
    +
    +### Bug Fixes
    +
    +* **telemetry:** timer-poll run.id ([#10672](#10672)) ([4185e77](4185e77)), closes [#10357](#10357) [#10357](#10357)
    +
    +
    +
     ### [0.6.3-u18.2](https://github.com/Agoric/agoric-sdk/compare/@agoric/telemetry@0.6.3-u18.1...@agoric/telemetry@0.6.3-u18.2) (2024-12-09)
     
     
    ```
    mujahidkay authored Dec 13, 2024
    Configuration menu
    Copy the full SHA
    1c820e7 View commit details
    Browse the repository at this point in the history

Commits on Dec 17, 2024

  1. Configuration menu
    Copy the full SHA
    e92f522 View commit details
    Browse the repository at this point in the history
  2. Save the contractKit for the auctioneer before overwriting it (#10694)

    refs: #10680
    
    ## Description
    
    We misplaced the adminFacets that would allow us to manage Auctions after they've been replaced and were about to do it again. The auctions were [last upgraded](https://github.com/Agoric/agoric-sdk/blob/43345a561fbdf7621c369abb15e6839f7c696565/packages/inter-protocol/src/proposals/add-auction.js#L157) in `agoric-upgrade-16av`. That code fails to save the instance's adminFacet, and only stores the contractKit in bootstrap promise space under the name `auctioneerKit`, where it will be overwritten on upgrade. Our other contracts now save a copy of the `contractKit` in either `contractKits` or `governedContractKits`, indexed by the instance, so the facets will hang around. This saves the old auctioneer during upgrade so we can manage it later (upgrade, terminate, change parameters).
    
    ### Security Considerations
    
    Losing our last handle for vats is a problem.
    
    ### Scaling Considerations
    
    We're upgrading vats to deal with scaling.
    
    ### Documentation Considerations
    
    None.
    
    ### Testing Considerations
    
    there was a test in #10680 which looked for this kit in `governedContractKits`, but I commented it out when it didn't succeed. It succeeds now.
    
    ### Upgrade Considerations
    
    Yes.
    Chris-Hibbert authored and mujahidkay committed Dec 17, 2024
    Configuration menu
    Copy the full SHA
    a10b0b5 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    56a550a View commit details
    Browse the repository at this point in the history
  4. test: add proposal w/300 E(chainTimerService).getTimerBrand() calls (#…

    …10696)
    
    ## Description
    
    @warner asked for a proposal that would ensure there were several more (300 was settled on) arbitrary calls in order to provoke bring-out-your-dead.
    
    ### Security Considerations
    
    test environments only: aimed at mainFork.
    
    ### Scaling Considerations
    
    No implications
    
    ### Documentation Considerations
    
    Unnecessary
    
    ### Testing Considerations
    
    For test environments.
    
    ### Upgrade Considerations
    
    None.
    Chris-Hibbert authored and mujahidkay committed Dec 17, 2024
    Configuration menu
    Copy the full SHA
    a66f809 View commit details
    Browse the repository at this point in the history
  5. build(deps): use backport of cosmos-sdk v0.46.15 (#10704)

    ## Description
    
    Update `cosmos-sdk` dependency to newly tagged Agoric version, `v0.46.16-alpha.agoric.2.5`
    
    ### Security Considerations
    
    Improves decoding of deeply nested transaction data.
    
    ### Scaling Considerations
    
    n/a
    
    ### Documentation Considerations
    
    n/a
    
    ### Testing Considerations
    
    Should be drop-in replacement for current dependencies.
    
    ### Upgrade Considerations
    
    n/a
    mergify[bot] authored and mujahidkay committed Dec 17, 2024
    Configuration menu
    Copy the full SHA
    28efa0f View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    540d4b1 View commit details
    Browse the repository at this point in the history
  7. chore: u18 cherrypicks round 6 (#10711)

    ### Description
    
    Cherry-picks the following commits from master:
    - #10696
    (3e27c74)
    - #10694
    (140c1be)
    - #10704
    (ab3fcb5,
    c025cb7)
    
    No new upgrade name has been added.
    
    Using following rebase todo:
    ```
    # PR #10704 Branch build-deps-use-backport-of-cosmos-sdk-v0-46-15-10704-
    label onto
    pick 140c1be Save the contractKit for the auctioneer before overwriting it (#10694)
    pick 3e27c74 test: add proposal w/300 E(chainTimerService).getTimerBrand() calls (#10696)
    label base-build-deps-use-backport-of-cosmos-sdk-v0-46-15-10704-
    pick ab3fcb5 build(deps): use backport of cosmos-sdk v0.46.15
    pick c025cb7 fix(cosmic-swingset): expect chain --halt-height exit status > 1
    label pr-10704--build-deps-use-backport-of-cosmos-sdk-v0-46-15-10704-
    reset base-build-deps-use-backport-of-cosmos-sdk-v0-46-15-10704- # test: add proposal w/300 E(chainTimerService).getTimerBrand() calls (#10696)
    merge -C 5939b2a pr-10704--build-deps-use-backport-of-cosmos-sdk-v0-46-15-10704- # build(deps): use backport of cosmos-sdk v0.46.15 (#10704)
    ```
    mujahidkay authored Dec 17, 2024
    Configuration menu
    Copy the full SHA
    0218510 View commit details
    Browse the repository at this point in the history
  8. chore(release): publish

     - @agoric/cosmos@0.35.0-u18.4
     - agoric@0.22.0-u18.5
     - @agoric/benchmark@0.1.1-u18.5
     - @agoric/boot@0.2.0-u18.5
     - @agoric/builders@0.2.0-u18.5
     - @agoric/casting@0.4.3-u18.4
     - @agoric/cosmic-proto@0.5.0-u18.4
     - @agoric/cosmic-swingset@0.42.0-u18.5
     - @agoric/create-dapp@0.1.1-u18.5
     - @agoric/deploy-script-support@0.10.4-u18.4
     - fast-usdc@0.1.1-u18.5
     - @agoric/inter-protocol@0.17.0-u18.5
     - @agoric/orchestration@0.2.0-u18.4
     - @agoric/pegasus@0.8.0-u18.4
     - @agoric/smart-wallet@0.5.4-u18.4
     - @agoric/solo@0.11.0-u18.5
     - @agoric/swingset-runner@0.22.3-u18.5
     - @agoric/vats@0.16.0-u18.4
     - @agoric/wallet-backend@0.15.0-u18.4
    mujahidkay committed Dec 17, 2024
    Configuration menu
    Copy the full SHA
    ff46c4a View commit details
    Browse the repository at this point in the history
Loading