Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vue tests & linting #47

Closed
roblevintennis opened this issue Nov 25, 2021 · 1 comment
Closed

Vue tests & linting #47

roblevintennis opened this issue Nov 25, 2021 · 1 comment
Labels
bug Something isn't working good first issue Good for newcomers

Comments

@roblevintennis
Copy link
Contributor

roblevintennis commented Nov 25, 2021

When we ported agnostic-vue to Vue 3 + Vite, we didn't yet address:

  • Linting issues
  • Tests

This task is to fix all that.

Also, we'll need to add back yarn test:vue to the top-level monorepo's package.json script:

    "test": "yarn sync:react && yarn test:react && yarn sync:vue && yarn sync:svelte && yarn test:svelte",

See https://github.com/AgnosticUI/agnosticui/blob/master/package.json#L41

@roblevintennis roblevintennis changed the title Vue tests Vue tests & linting Nov 25, 2021
@roblevintennis roblevintennis added good first issue Good for newcomers bug Something isn't working labels Nov 27, 2021
@roblevintennis
Copy link
Contributor Author

I got the Eslint working and cleaned up the files.

For testing, Jest and Vite seems to be a shit show. Will rewvisit specs using idiomatic vite/vue 3 way.

vitejs/vite#1955

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

1 participant