Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[AGE-433] [bug] New exact match and JSON evaluators are created with each served variant #1901

Closed
mmabrouk opened this issue Jul 16, 2024 · 5 comments
Assignees
Labels
Backend bug Something isn't working good first issue Good for newcomers Low priority Created by Linear-GitHub Sync
Milestone

Comments

@mmabrouk
Copy link
Member

To reproduce:

  • Create an app from cli (agenta init)

  • Serve variant 1

  • Create new code (app2.py) and serve variant2

    A new exact match and contains json evaluator will be created: https://share.cleanshot.com/QWVWKpFJ

    CleanShot 2024-07-16 at 16.06.07@2x.png

Correct behavior:

  • Exact match and contains json are only created when the app is initialized and not at each variant serve

From SyncLinear.com | AGE-433

@mmabrouk mmabrouk added Backend bug Something isn't working good first issue Good for newcomers Low priority Created by Linear-GitHub Sync labels Jul 16, 2024
@Dozie2001
Copy link

Hello Interested in tackling this issue can I get more info

@mmabrouk
Copy link
Member Author

Hi @Dozie2001 ,

It looks like the issue is here. Each time we create a new variant, we call create_ready_to_use_evaluators which creates these evaluators. However this should only be done when we create an app and now when we create a variant. The solution to call create_ready_to_use_evaluators when we create the app and not here and here. So it should happen here, hope this helps.

@mmabrouk
Copy link
Member Author

I've assigned it to you @Dozie2001 let me know if that would work.

@Dozie2001
Copy link

Dozie2001 commented Jul 26, 2024

Ok will get to it now

@mmabrouk
Copy link
Member Author

I am closing this now, we will tackle it in a new issue related to the release

@mmabrouk mmabrouk added this to the v.64 milestone Nov 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Backend bug Something isn't working good first issue Good for newcomers Low priority Created by Linear-GitHub Sync
Projects
None yet
Development

No branches or pull requests

2 participants