Skip to content

Conversation

@areibman
Copy link
Contributor

📥 Pull Request

📘 Description
Autogen gets re-loaded on start session. Blocking.

🧪 Testing
remove reload

@areibman areibman changed the title Fix autogen reload [draft] Fix autogen reload Oct 28, 2024
@gitguardian
Copy link

gitguardian bot commented Oct 28, 2024

⚠️ GitGuardian has uncovered 2 secrets following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

🔎 Detected hardcoded secrets in your pull request
GitGuardian id GitGuardian status Secret Commit Filename
14166767 Triggered Generic High Entropy Secret d0524a6 latency.py View secret
14166767 Triggered Generic High Entropy Secret 0a673cd latency.py View secret
🛠 Guidelines to remediate hardcoded secrets
  1. Understand the implications of revoking this secret by investigating where it is used in your code.
  2. Replace and store your secrets safely. Learn here the best practices.
  3. Revoke and rotate these secrets.
  4. If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.

To avoid such incidents in the future consider


🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

@codecov
Copy link

codecov bot commented Oct 29, 2024

Codecov Report

Attention: Patch coverage is 88.04348% with 11 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
agentops/helpers.py 40.00% 9 Missing ⚠️
agentops/__init__.py 0.00% 1 Missing ⚠️
agentops/client.py 50.00% 1 Missing ⚠️
Flag Coverage Δ
unittests 56.66% <88.04%> (+12.06%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
agentops/host_env.py 68.83% <ø> (ø)
tests/test_agent.py 100.00% <ø> (ø)
tests/test_canary.py 100.00% <100.00%> (ø)
tests/test_events.py 100.00% <100.00%> (ø)
tests/test_pre_init.py 100.00% <100.00%> (ø)
tests/test_record_action.py 98.80% <100.00%> (ø)
tests/test_record_tool.py 98.77% <100.00%> (ø)
tests/test_session.py 100.00% <100.00%> (ø)
tests/test_teardown.py 100.00% <100.00%> (ø)
agentops/__init__.py 46.87% <0.00%> (-0.50%) ⬇️
... and 2 more

... and 8 files with indirect coverage changes

@areibman areibman changed the title [draft] Fix autogen reload Fix autogen reload Oct 31, 2024
@areibman
Copy link
Contributor Author

Old: Program took 4.21 seconds to run
New: Program took 0.39 seconds to run

To test:

import agentops
import time

start_time = time.time()

agentops.init()


@agentops.record_action('func')
def func():
    return 1


func()
end_session_start = time.time()
end_session_end = time.time()
print(f"end_session took {end_session_end - end_session_start:.2f} seconds")

end_time = time.time()
print(f"Program took {end_time - start_time:.2f} seconds to run")

Copy link
Contributor

@siyangqiu siyangqiu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You should have @bboynton97 check this as well, since she wrote the autogen integration

@areibman areibman merged commit f4d8347 into main Nov 1, 2024
11 of 12 checks passed
@areibman areibman deleted the fix_autogen_reload branch November 1, 2024 02:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants