Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dead letter queue #385

Open
wants to merge 17 commits into
base: main
Choose a base branch
from
Open

Dead letter queue #385

wants to merge 17 commits into from

Conversation

bboynton97
Copy link
Contributor

closes ENG-565

Failed requests are retried.
After 3 failures, they are stored in-memory with a queue.
When a request succeeds, the queue attempts to retry.

@bboynton97
Copy link
Contributor Author

Add persistent storage and show users logs when a request fails

Copy link

codecov bot commented Sep 18, 2024

Codecov Report

Attention: Patch coverage is 73.68421% with 20 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
agentops/http_client.py 77.61% 12 Missing and 3 partials ⚠️
agentops/helpers.py 44.44% 3 Missing and 2 partials ⚠️
Flag Coverage Δ
unittests 46.16% <73.68%> (+1.76%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
agentops/helpers.py 64.00% <44.44%> (-1.94%) ⬇️
agentops/http_client.py 71.51% <77.61%> (+27.71%) ⬆️

@bboynton97
Copy link
Contributor Author

ready for review again @siyangqiu

Copy link

gitguardian bot commented Sep 21, 2024

⚠️ GitGuardian has uncovered 1 secret following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

🔎 Detected hardcoded secret in your pull request
GitGuardian id GitGuardian status Secret Commit Filename
13866639 Triggered Generic High Entropy Secret 1a7cba1 tests/core_manual_tests/http_client/dead_letter_queue.py View secret
🛠 Guidelines to remediate hardcoded secrets
  1. Understand the implications of revoking this secret by investigating where it is used in your code.
  2. Replace and store your secret safely. Learn here the best practices.
  3. Revoke and rotate this secret.
  4. If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.

To avoid such incidents in the future consider


🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant