simple fix of types of globals #314
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As mentioned in #310 , here's a fix to the problem mentioned there. But instead of the more complex substitution as in #308 , we simply fix it by using the tagged type of the place.
Notably, in #308 , we will need to fetch the vtable instance pointer, and substitute the generics with the generics args from the reference to generate the correct type ourselves. But in
PlaceGlobal, we have available type tagged by Charon.Further, please note that the tagged type may not yield exactly the same result as the substitution -- because of the difference in lifetime parameters.
As mentioned in #310 , there might be more hidden bugs like this.