Make charon-lib fully independent from rustc
#474
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Nadrieril
changed the title
charon-lib fully independent of rustccharon-lib fully independent from rustc
Nadrieril
force-pushed
the
annotate-snippets
branch
from
7bae81d to
9522092
Compare
github-merge-queue bot
pushed a commit
to model-checking/kani
that referenced
this pull request
Jan 3, 2025
Update Charon submodule to AeneasVerif/charon@adc0a85 Relevant Charon PRs: AeneasVerif/charon#457: This required updating the code that creates places to also pass in the type. AeneasVerif/charon#464: This replaced the file-to-id hash table by a vector, thus requiring that we add one in Kani's translation context. AeneasVerif/charon#474: The translation context is no longer parameterized by a lifetime AeneasVerif/charon#491: This required changing the type of indices By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 and MIT licenses. --------- Co-authored-by: thanhnguyen-aws <ntson@amazon.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR switches to
annotate-snippetsto display error messages. This makes it possible to remove 100% of rustc internal dependencies fromcharon-lib(Spandoesn't even need to hold a rustcSpananymore). This should also fix the issues in #145 where errors were miscategorized as panics.Fixes #409.