Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ariaLiveSRPane is not being removed from the DOM #2835

Closed
mark-hingston opened this issue Sep 6, 2024 · 3 comments
Closed

ariaLiveSRPane is not being removed from the DOM #2835

mark-hingston opened this issue Sep 6, 2024 · 3 comments
Labels
Needs more info Further information is requested Stale

Comments

@mark-hingston
Copy link

Describe the bug
The #ariaLiveSRPane doesn't seem to be removed from the DOM when the drop-in component is unmounted.

To Reproduce
Steps to reproduce the behavior:

  1. Complete a payment using Adyen drop-in
  2. The #ariaLiveSRPane container remains on the page after the Adyen drop-in component is unmounted.
<div class="sr-panel-holder" id="ariaLiveSRPanel"><div class="adyen-checkout-sr-panel--sr-only" role="log" aria-relevant="additions text" aria-live="polite" aria-atomic="true"><div class="adyen-checkout-sr-panel__msg">Payment Successful</div></div></div>

Expected behavior
The #ariaLiveSRPanel should be removed when the component is unmounted.

Additional context
@adyen/adyen-web: 6.0.2

@sponglord
Copy link
Contributor

sponglord commented Sep 10, 2024

@mark-hingston - the ariaLiveSRPanel is a checkout level module and, as such, is not dependent on the presence, or not, of any component level entities (like Dropin, or a specific paymentMethod related component).

Thus it sits free from any component's mount/unmount process.

What trouble is its continued presence in the DOM causing?

@sponglord sponglord added the Needs more info Further information is requested label Sep 10, 2024
Copy link
Contributor

This issue is stale because it has been open 30 days with no activity. Please comment on this issue otherwise it will be closed in 7 days.

@github-actions github-actions bot added the Stale label Oct 11, 2024
Copy link
Contributor

This issue was closed because it has been stalled for 7 days with no activity.

@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Oct 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Needs more info Further information is requested Stale
Projects
None yet
Development

No branches or pull requests

2 participants