Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix invalid method usage for sw version < 6.4.17.0 #514

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

lx-wnk
Copy link

@lx-wnk lx-wnk commented Jul 3, 2024

This change resolves an error due to the usage of not available methods for older Shopware versions.

The method getCurrentContext was introduced with 6.4.17.0 (see here).

Before this there was no method like this so I added an early return instead.
This currently breaks a stage system with version 6.4.14.0.

As stated in the Shopware store, this plugin is currently compatible with the version range: 6.3.1.1 - 6.5.8.11

@lx-wnk lx-wnk requested a review from a team as a code owner July 3, 2024 14:46
@lx-wnk lx-wnk mentioned this pull request Jul 10, 2024
@lx-wnk
Copy link
Author

lx-wnk commented Jul 22, 2024

@SushmitaThakur could you look over this PR or redistribute it? This is a necessary fix for versions below 6.4.17.0

@khushboo-singhvi
Copy link
Contributor

Hello @lx-wnk,

Thank you for your feedback and for bringing this issue to our attention.

We understand that the usage of the getCurrentContext method, introduced in Shopware version 6.4.17.0, is causing compatibility issues with older versions, specifically with version 6.4.14.0.

At this time, our current focus is on supporting Shopware version 6.6 and above. And this PR is branched out from V4 of the plugin which only supports Shopware6.6+. Therefore, the changes in this PR may not be compatible with older versions as listed.

We encourage you to make the necessary adjustments in your environment to ensure compatibility with the version you are using. We appreciate your understanding and cooperation.

Thank you for your continued support.

Best regards,
Khushboo Singhvi

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants