Properly handling the onChange for first pre-selected payment method #1097
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…riants components
|
zenit2001
changed the title
zenit2001
requested review from
maassenbas,
amihajlovski and
shanikantsingh
as code owners
shanikantsingh
approved these changes
Jul 3, 2024
amihajlovski
approved these changes
Jul 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Describe the changes proposed in this pull request:
Validation was failing when the first pre-selected pm was being used to complete a payment, preventing the shopper to go to order review page. This issue was happening only for components which don't have additional fields.
Changes
handleOnChangefunction to get the type of payment method from stateData and handles the multiple tx variant components.Tested scenarios
Description of tested scenarios:
Fixed issue: SFI-795