Fix PayPal popup infinite loading spinner if T&Cs are not checked #2659
Conversation
… checked If the checkout form is not valid and the user clicks on the PayPal button, the popup will be opened with an infinite loading spinner. Event if the customer closes the popup, checks the checkbox and clicks again on the PayPal button, the popup will not work anymore, until the page is reloaded.
|
Hello @Axel29, Thank you for your contribution. I've tested the implementation and have some comments. PayPal_TC_infinite_loader.mp4Implementation works fine and solves the issue if the user arrives on payment method selection page from shipping address and method selection page. (See the first part of the video). However, if the user refreshes the page on the payment method selection page, a race condition occurs. After the refresh, the code is executed before the page is loaded. T&C checkbox is mounted to the checkout after loading the payment method. So, the selector for the input box is always null (See the second part of the video). Do you have any recommendation for solving this race condition? Best Regards, |
| * closes the popup, checks the checkbox and clicks again on the PayPal button, the popup will not work | ||
| * anymore, until the page is reloaded. | ||
| */ | ||
| let checkoutAgreementsInput = document.querySelector('.checkout-agreement input'); |
There was a problem hiding this comment.
Race condition occurs if the payment method page is refreshed. See my comment here.
Description
Add
onInitandonClickfunctions to the configuration object in order to maange the PayPal Buttons state (enabled / disabled) depending on the checkout agreements checkbox state.Without these functions, if the form is not valid (checkbox unchecked) and the user clicks on the PayPal button, the popup will be opened with an infinite loading spinner, and even if the customer closes the popup, checks the checkbox and clicks again on the PayPal button, the popup will not work anymore, until the page is reloaded.
Tested scenarios
Expected result
Fixes #2613