-
Notifications
You must be signed in to change notification settings - Fork 140
Release v38.1.0 #1489
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Release v38.1.0 #1489
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hello @AdyenAutomationBot, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
Summary of Changes
Hello team, gemini-code-assist here to provide a summary of this pull request. This PR appears to be an automated release PR, bumping the library version from 38.0.0
to 38.0.1
. This typically signifies a patch release, likely incorporating changes from the merged pull request #1486 as noted in the description. The changes involve updating the version string across various project configuration and source files.
Highlights
- Version Bump: The primary change is the increment of the library version from
38.0.0
to38.0.1
. - Configuration Updates: The version number has been updated in key project files including the
pom.xml
(Maven configuration),VERSION
file,README.md
documentation, and the internalLIB_VERSION
constant in theClient.java
source file.
Changelog
- README.md
- Updated the Maven dependency version example from
38.0.0
to38.0.1
. - Updated the Support Team contact link URL, changing
38.0.0705420
to38.0.1705420
.
- Updated the Maven dependency version example from
- VERSION
- Updated the version string from
38.0.0
to38.0.1
.
- Updated the version string from
- pom.xml
- Updated the project version in the Maven configuration from
38.0.0
to38.0.1
.
- Updated the project version in the Maven configuration from
- src/main/java/com/adyen/Client.java
- Updated the
LIB_VERSION
constant from"38.0.0"
to"38.0.1"
.
- Updated the
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command>
or @gemini-code-assist <command>
. Below is a summary of the supported commands.
Feature | Command | Description |
---|---|---|
Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in issue comments and review comments. |
Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/
folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist is currently in preview and may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments to provide feedback.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
Version number climbs,
Patch release, small fix goes out,
Code gets better now.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request updates the library version from 38.0.0
to 38.0.1
. The changes are consistent across pom.xml
, README.md
, VERSION
, and src/main/java/com/adyen/Client.java
.
One point requires clarification regarding an updated URL in the README.md
, as detailed in the specific comment.
Summary of Findings
- Support Link
ticket_form_id
Update: Theticket_form_id
in a support link inREADME.md
was automatically updated. Confirmation is requested to ensure the link remains functional, as automated string replacement can sometimes have unintended side effects on complex IDs. - Release Process Automation (Observation): The
VERSION
file was updated as part of this release, but it's not listed in thefileList
of theupgrade_release_version.sh
script provided in the repository context. This suggests theVERSION
file might be updated manually or by a different part of the release process. For full automation consistency, if this script is the primary tool, consider includingVERSION
file updates within it. (This is an observation and not a comment on the PR's code changes due to review settings: low severity/process observation).
Merge Readiness
The pull request primarily consists of version string updates for the v38.0.1
release, which are consistently applied. However, there is one medium-severity concern regarding an automated change to a ticket_form_id
in a URL within README.md
. It is recommended to confirm the correctness of this specific URL change before merging to ensure the support link remains functional. I am not authorized to approve pull requests, but I advise addressing or acknowledging the comment before proceeding with the merge. Other reviewers should provide final approval.
README.md
Outdated
@@ -554,7 +554,7 @@ Have a look at our [contributing guidelines](CONTRIBUTING.md) to find out how to | |||
## Support | |||
If you have a feature request, or spotted a bug or a technical problem, [create an issue here](https://github.com/Adyen/adyen-java-api-library/issues/new/choose). | |||
|
|||
For other questions, [contact our Support Team](https://www.adyen.help/hc/en-us/requests/new?ticket_form_id=38.0.0705420). | |||
For other questions, [contact our Support Team](https://www.adyen.help/hc/en-us/requests/new?ticket_form_id=38.0.1705420). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The ticket_form_id
in the support link has been updated from 38.0.0705420
to 38.0.1705420
. This change appears to be the result of the automated version replacement script (upgrade_release_version.sh
found in the repository) replacing the string 38.0.0
with 38.0.1
.
Could you please confirm if this modification to the ticket_form_id
is correct and intentional?
- If the
ticket_form_id
is dynamically constructed using the library version (e.g.,VERSION_STRING + "705420"
), then this automated update is likely correct. - However, if
38.0.0705420
was a specific, fixed ID that coincidentally contained the old version string, this change might inadvertently break the link.
Ensuring this link directs users to the correct support form is important for user experience.
c2be634
to
7a24e86
Compare
7a24e86
to
797b845
Compare
797b845
to
2f1f98e
Compare
Merged pull requests to be released:
Full Changelog: v38.0.0...main