Skip to content

Commit 7184291

Browse files
committed
add contributing section
1 parent d15a660 commit 7184291

File tree

2 files changed

+12
-2
lines changed

2 files changed

+12
-2
lines changed

.gitignore

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -128,4 +128,8 @@ dmypy.json
128128
# Pyre type checker
129129
.pyre/
130130

131+
# pyvenv
132+
pyvenv.cfg
133+
bin/
134+
131135
version.txt

README.md

Lines changed: 8 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,7 @@ pip install fastapi-cloud-tasks
1919
- Tasks are regular FastAPI endpoints on plain old HTTP.
2020
- `Depends` just works!
2121
- All middlewares, telemetry, auth, debugging etc solutions for FastAPI work as is.
22-
- Host task runners it independent of GCP. If CloudTasks can reach the URL, it can invoke the task.
22+
- Host task runners independent of GCP. If CloudTasks can reach the URL, it can invoke the task.
2323
- Save money.
2424
- Task invocation with GCP is [free for first million, then costs $0.4/million](https://cloud.google.com/tasks/pricing).
2525
That's almost always cheaper than running a RabbitMQ/Redis/SQL backend for celery.
@@ -103,7 +103,7 @@ FastAPI Cloud Tasks works by putting the three together:
103103
### Local
104104

105105
Pre-requisites:
106-
- `pip install local-requirements.txt`
106+
- `pip install fastapi-cloud-tasks`
107107
- Install [cloud-tasks-emulator](https://github.com/aertje/cloud-tasks-emulator)
108108
- Alternatively install ngrok and forward the server's port
109109

@@ -332,4 +332,10 @@ async def my_task(ct_headers: CloudTasksHeaders = Depends()):
332332

333333
Check the file [fastapi_cloud_tasks/dependencies.py](fastapi_cloud_tasks/dependencies.py) for details.
334334

335+
## Contributing
336+
337+
- Run `pre-commit install` on your local to get pre-commit hook.
338+
- Make changes and raise a PR!
339+
- If the change is massive, open an issue to discuss it before writing code.
340+
335341
Note: This project is neither affiliated with, nor sponsored by Google.

0 commit comments

Comments
 (0)