Skip to content

Commit 1d6872b

Browse files
committed
Remove MiraiLogger.subLogger in mirai-core-api to overcome declaration clash on native
1 parent b9e6657 commit 1d6872b

File tree

2 files changed

+19
-20
lines changed

2 files changed

+19
-20
lines changed

mirai-core-api/src/commonMain/kotlin/internal/utils/MarkedMiraiLogger.kt

Lines changed: 12 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -10,8 +10,6 @@
1010
package net.mamoe.mirai.internal.utils
1111

1212
import net.mamoe.mirai.utils.MiraiLogger
13-
import kotlin.jvm.JvmName
14-
import kotlin.native.CName
1513

1614
/**
1715
* 内部添加 [Marker] 支持, 并兼容旧 [MiraiLogger] API.
@@ -39,16 +37,18 @@ internal fun Marker(name: String, vararg parents: Marker?): Marker {
3937

4038
internal val MiraiLogger.markerOrNull get() = (this as? MarkedMiraiLogger)?.marker
4139

42-
/**
43-
* Create a marked logger whose marker is a child of this' marker.
44-
*
45-
* Calling [MarkedMiraiLogger.subLogger] if possible, and creating [MiraiLoggerMarkedWrapper] otherwise.
46-
*/
47-
@JvmName("subLoggerImpl2")
48-
@CName("", "subLogger2")
49-
internal fun MiraiLogger.subLogger(name: String): MiraiLogger {
50-
return subLoggerImpl(this, name)
51-
}
40+
// This clashes with the same declaration in mirai-core (same package), for native.
41+
//
42+
///**
43+
// * Create a marked logger whose marker is a child of this' marker.
44+
// *
45+
// * Calling [MarkedMiraiLogger.subLogger] if possible, and creating [MiraiLoggerMarkedWrapper] otherwise.
46+
// */
47+
//@JvmName("subLoggerImpl2")
48+
//@CName("", "subLogger2")
49+
//internal fun MiraiLogger.subLogger(name: String): MiraiLogger {
50+
// return subLoggerImpl(this, name)
51+
//}
5252

5353
// used by mirai-core
5454
internal fun subLoggerImpl(origin: MiraiLogger, name: String): MiraiLogger {

mirai-core-api/src/jvmBaseTest/kotlin/logging/Log4j2LoggingTest.kt

Lines changed: 7 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -16,12 +16,7 @@ import net.mamoe.mirai.utils.LoggerAdapters.asMiraiLogger
1616
import net.mamoe.mirai.utils.MiraiLogger
1717
import org.apache.logging.log4j.LogManager
1818
import org.junit.jupiter.api.AfterEach
19-
import org.junit.jupiter.api.BeforeEach
20-
import kotlin.test.BeforeTest
21-
import kotlin.test.Test
22-
import kotlin.test.assertEquals
23-
import kotlin.test.assertIs
24-
import kotlin.test.assertSame
19+
import kotlin.test.*
2520

2621
internal class Log4j2LoggingTest {
2722
@BeforeTest
@@ -56,7 +51,7 @@ internal class Log4j2LoggingTest {
5651
val parent = MiraiLogger.Factory.create(Log4j2LoggingTest::class, "test1")
5752
val parentMarker = parent.cast().marker!!
5853

59-
val child = parent.subLogger("sub")
54+
val child = subLoggerImpl(parent, "sub")
6055
val childMarker = child.markerOrNull!!
6156

6257
assertEquals("test1", parentMarker.name)
@@ -89,4 +84,8 @@ internal class Log4j2LoggingTest {
8984
info("InfoFF")
9085
}
9186
}
92-
}
87+
}
88+
89+
internal fun MiraiLogger.subLogger(s: String): MiraiLogger {
90+
return subLoggerImpl(this, s)
91+
}

0 commit comments

Comments
 (0)