feat: Form element custom rendering in Content Fragment Editor #63
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
-- update menu links
-- update header types
-- small text fixes
naydav
changed the title
# Conflicts: # gatsby-config.js # src/pages/services/aem-cf-editor/api/custom-fields/index.md # src/pages/services/aem-cf-editor/api/index.md
vkublytskyi
requested changes
Nov 10, 2023
| |-----------------------------------------------------|--------------------------------------------------------------------------------------------------------------------------------------------------------| | ||
| | `getModel(): Object` | Return Content Fragment Model for the currently edited Content Fragment. | | ||
| | `getDefaultValue(): mixed` | Returns the initial value for the input we are replacing. | | ||
| | `getValidationState(): invalid|valid` | Returns the validation state value for the input we are replacing. | |
There was a problem hiding this comment.
Is it string with two possible values or a boolean?
There was a problem hiding this comment.
|
|
||
| | Method | Description | | ||
| |-----------------------------------------------------|--------------------------------------------------------------------------------------------------------------------------------------------------------| | ||
| | `getModel(): Object` | Return Content Fragment Model for the currently edited Content Fragment. | |
There was a problem hiding this comment.
Can we describe at least major fields of the object?
| | `getModel(): Object` | Return Content Fragment Model for the currently edited Content Fragment. | | ||
| | `getDefaultValue(): mixed` | Returns the initial value for the input we are replacing. | | ||
| | `getValidationState(): invalid|valid` | Returns the validation state value for the input we are replacing. | | ||
| | `onValidationStateChange(Function callback): void` | Accepts a callback that will be called when the validation state changes for the input we are replacing. | |
There was a problem hiding this comment.
What is a callback signature? Does it accept any arguments?
| | `getDefaultValue(): mixed` | Returns the initial value for the input we are replacing. | | ||
| | `getValidationState(): invalid|valid` | Returns the validation state value for the input we are replacing. | | ||
| | `onValidationStateChange(Function callback): void` | Accepts a callback that will be called when the validation state changes for the input we are replacing. | | ||
| | `onChange(Function callback): void` | Accepts a callback that will be called when the value of the input we are replacing changes. | |
There was a problem hiding this comment.
What is a callback signature? Does it accept any arguments?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://jira.corp.adobe.com/browse/SITES-16081
https://developer-stage.adobe.com/uix/docs/services/aem-cf-editor/api/custom-fields/