Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unable to drag and drop the component from sidekick in AEM 6.4 using classic UI. classicui-limit-parsys.js limit is undefined. #1759

Closed
3 tasks
lokeshvajrala opened this issue Feb 19, 2019 · 4 comments

Comments

@lokeshvajrala
Copy link
Contributor

Required Information

  • AEM Version, including Service Packs, Cumulative Fix Packs, etc: 6.4.2
  • ACS AEM Commons Version: 3.17.4
  • Reproducible on Latest? yes

Expected Behavior

Should be able to drag & drop the components from sidekick on to the parsys.

Actual Behavior

Drag & drop the component from the sidekick to the pasrys isn't working in classic UI and there is console error from this file https://github.com/Adobe-Consulting-Services/acs-aem-commons/blob/master/content/src/main/content/jcr_root/apps/acs-commons/widgets/configure-limit-parsys/classicui-limit-parsys.js#L96.
It looks like sometimes the "designObject" is not initialized within the pageInfo and just returns as an undefined limit object.
image

Steps to Reproduce

  1. Start AEM 6.4.2
  2. Install ACS commons 3.17.4 or the latest.
  3. Install the attached content package.
  4. Open the page http://localhost:4502/content/parsys-drag-drop-issue.html
  5. Drag & drop the component to the parsys to see the console error. Some times it works, so try refreshing the window or try in the incognito window.

classicUI-drag-drop-issue-0.1.zip

Links

@kwin
Copy link
Contributor

kwin commented Feb 28, 2019

Isn't this a duplicate of #1516?
@lokeshvajrala Can you try either 3.19.0 or newer?

@davidjgonzalez
Copy link
Contributor

Closing as a dupe of #1516 as @kwin mentions. Please re-open if this turns out it is not a duplicate and still exists in 3.19.0+.

@lokeshvajrala
Copy link
Contributor Author

@kwin, @davidjgonzalez Tested with the latest version (4.0.0), it seems like the issue still exists. The problem is with the limit object at https://github.com/Adobe-Consulting-Services/acs-aem-commons/blob/master/content/src/main/content/jcr_root/apps/acs-commons/widgets/configure-limit-parsys/classicui-limit-parsys.js#L96. as it is undefined sometimes due to the undefined "pageInfo.designObject " at #L55. Also, created a PR to resolve the issue - #1787

Content package to reproduce the issue:
classicUI-drag-drop-issue-0.2.zip

@ghost
Copy link

ghost commented Jun 12, 2019

Is this issue fixed?
I tried with latest version of ACS (4.1.0) and issues still exists.
We are also getting same error on all environment including prod. And business is not able to drag and drop any component in parsys.
Could you please fix it as soon as possible? It is very critical issue for editors.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants