Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

$all modifier does not work with non-domain-like URL part #1860

Closed
Alex-302 opened this issue Feb 12, 2024 · 2 comments
Closed

$all modifier does not work with non-domain-like URL part #1860

Alex-302 opened this issue Feb 12, 2024 · 2 comments

Comments

@Alex-302
Copy link
Member

AdGuard 7.17.0 nightly 2 (4585) (CL 1.13.118, DL 2.4.38 )
Chrome 121

Steps to reproduce

  1. Disable all filters, DNS filtering, safebrowsing
  2. Add &pbsubid=$all rule to user rules
  3. Open http://iyfbodn.com/?dn=maphuahin.com&pid=9POT3387I&pbsubid=f3de3781-7342-44ad-8fd6-4839cebfd6d7&noads=http

Expected behavior

URL is blocked with a dummy, like with ||iyfbodn.com^$all

Details

image

Actual behavior

The page is loaded.

Also http$all only blocks resources of pages.

Details
@sfionov
Copy link
Member

sfionov commented Feb 13, 2024

@Alex-302 Domain does not exist, and with https://example.org/?dn=maphuahin.com&pid=9POT3387I&pbsubid=f3de3781-7342-44ad-8fd6-4839cebfd6d7&noads=http it works as expected.

@sfionov
Copy link
Member

sfionov commented Feb 13, 2024

Ok, I see. works with https:// but http:// does not match.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants