Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

$jsonprune modifier should be able to handle quotes for jsonp #1734

Closed
contribucious opened this issue Mar 3, 2023 · 1 comment
Closed

Comments

@contribucious
Copy link

Hello,

This is an enhancement request regarding the jsonp support.

Problem

Working example — Yandex, from here:
Ya[1696872491473]('{…json…}')
Not working example — FreeWheel, a Comcast company, from $replace rules here:
tv.freewheel.SDK._instanceQueue['Context_1'].requestComplete('{…json…}')

Resolution

According to my tests, just need to add support for single (and also ideally, double) quotes for jsonp.

↪️ In a controlled environment, removing quotes by using [Context_1] instead will make the thing work.

 


💻 AdGuard 7.13 nightly 3 (build 4206, CL 1.11.50) on Windows 10 Pro. | Thanks! ✌️
@contribucious
Copy link
Author

Simple change, yes, but … thank you for this speed!

Kudos to the AG team!
↪️ I mean … the A team! #TheITCrowd

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants