Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for CIDR in "$network" #1646

Open
DandelionSprout opened this issue Aug 1, 2020 · 2 comments
Open

Add support for CIDR in "$network" #1646

DandelionSprout opened this issue Aug 1, 2020 · 2 comments

Comments

@DandelionSprout
Copy link
Member

DandelionSprout commented Aug 1, 2020

I received a good tip on Slack that propellerads primarily rotate their domains within the CIDR range 139.45.192.0/18, as seen with https://securitytrails.com/list/ip/139.45.192.0%2f18. So I initially opened up my AdGuard for Windows installation and tried to enter 139.45.192.0/18$network into the "User Filters"... and saw that AdGuard refused that entry, claiming it was incorrectly formatted.

Thus I propose adding CIDR support in $network blocking rules.

The alternative would be for AdGuard Base to add entries against all 16,384 individual IP addresses, which I assume would be very impractical.

Steps to reproduce

  1. Go to Settings → Adblocker → User filter
  2. Try to add 139.45.192.0/18$network as a new entry.
  3. See that the textbox receives red error edges and that AdGuard refuses to save the entry.

Expected behavior

CIDR can be used in $network entries.

Actual behavior

CIDR cannot be used in $network entries.

Screenshot:

image

Customer ID

Can't find within the AdGuard program.

Your environment

  • Environment name and version: AdGuard for Windows 7.4.2
  • Operating system and version: Windows 10 May 2020 Update, build 19041.388
@Alex-302
Copy link
Member

Alex-302 commented Aug 2, 2020

But too much useful sites will be blocked. Of the first look - ati.su(477-513)

@DandelionSprout
Copy link
Member Author

Okay, that is admittedly a fair point.

@adbuker adbuker transferred this issue from AdguardTeam/AdguardForWindows Jun 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants