-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support redirection to the destination, without tracking services as middleman #1557
Comments
Hello, The uBlockOrigin developer said he will consider adding this capability after Adguard: uBlockOrigin/uBlock-issues#1784 But it appears it does it now, but not automatically: https://github.com/gorhill/uBlock/wiki/Strict-blocking#ability-to-parse-the-strict-blocked-url |
Duplicates #1364, please upvote it if you need it. |
Since $urltransform is only for same-origin redirects, I'm reopening this issue. |
I will not lie, I am disappointed :/ I’ve been waiting for this feature for 3 years, as I already said in #1364 asking for news. All this said, I have full confidence in the Adguard team and you, developers, are doing a fantastic job. I am a big fan of Adguard products and I will wait patiently for a new solution to be developed. I just hope not to have to wait again 3 years :( As I said previously, uBlock Origin can do it now, if I'm not mistaken. Thanks again. |
Any progress on this? I've noticed that CoreLibs v1.16.19 seems to address this issue, but how exactly does it work? |
I would test under windows, updating in AdGuard v7.19. But I can’t find a doc explaining how it’s implemented. |
@cxplay did you find out how to do it ? |
No yet |
Here is information about changing origin - https://adguard.com/kb/general/ad-filtering/create-own-filters/#urltransform-modifier:~:text=this%3A%20%5C%2C.-,Changing%20the%20origin,-COMPATIBILITY
For example, to redirect all searches from ||google.*/search?q=$urltransform=/^https?:\/\/.*google\..*\/search\?q=([^&]+)&?.*/https:\/\/duckduckgo.com\/?q=\$1/ can be used. The problem might be in the case of encoded URL.
The /^https?:\/\/(?:[a-z0-9-]+\.)*?(?:track\.effiliation\.com\/servlet\/effi\.redir|dealabs\.digidip\.net\/visit\?url=)/$urltransform=/%3A/:/
/^https?:\/\/(?:[a-z0-9-]+\.)*?(?:track\.effiliation\.com\/servlet\/effi\.redir|dealabs\.digidip\.net\/visit\?url=)/$urltransform=/%2F/\//
/^https?:\/\/(?:[a-z0-9-]+\.)*?(?:track\.effiliation\.com\/servlet\/effi\.redir|dealabs\.digidip\.net\/visit\?url=)/$urltransform=/%3F/?/
/^https?:\/\/(?:[a-z0-9-]+\.)*?(?:track\.effiliation\.com\/servlet\/effi\.redir|dealabs\.digidip\.net\/visit\?url=)/$urltransform=/%3D/=/
/^https?:\/\/(?:[a-z0-9-]+\.)*?(?:track\.effiliation\.com\/servlet\/effi\.redir|dealabs\.digidip\.net\/visit\?url=)/$urltransform=/^https?:\/\/(?:[a-z0-9-]+\.)*?(?:effiliation\.com|dealabs\.digidip\.net).*url=([^&]*)/\$1/ I guess that it would be useful to have an option to decode URL. |
I've noticed the urltransform. But, yes, there is no better solution for URL encoding. |
Hello @ngorskikh |
@imTHAI commented on Tue Nov 30 2021
Hello,
I would like Adguard support the URL redirect with cleaning the tracking. Like ClearURLs add-on does.
Indeed both Adguard (with $removeparam I believe ?) and ClearURLs can clean tracking code after the URL
For example:
https://example.com?utm_source=newsletter1&utm_medium=email&utm_campaign=sale
After the address is cleaned, it will look like this:
https://www.amazon.com/dp/exampleProduct
But clearURLs also cleans in case of redirection. That's the purpose of my request:
For example:
If I click on a link like this one:
https://dealabs.digidip.net/visit?url=https%3A%2F%2Fwww.amazon.fr%2Fdp%2FB098K16RX5%3Fsmid%3DA1X6FK5RDHNB96&ppref=https%3A%2F%2Fwww.dealabs.com%2Fbons-plans%2Fasus-zenbook-um425qa-14-fhd-amd-ryzen-7-5800h-ram-16go-512-go-w10-azerty-2256311
With ClearURLs it will be cleaned to:
https://www.amazon.fr/dp/B098K16RX5?smid=A1X6FK5RDHNB96
Another example:
http://track.effiliation.com/servlet/effi.redir?id_compteur=12305754&effi_id=0k003mdl0mwv&url=https%3A%2F%2Ffr.shopping.rakuten.com%2Foffer%3Faction%3Ddesc%26aid%3D9027491774%26productid%3D6956351445
With ClearURLs it will be cleaned to:
https://fr.shopping.rakuten.com/offer?action=desc&aid=9027491774&productid=6956351445
(with Safari/Adguard, it will give me an error page since track.effiliation.com is blocked by my AdguardHome dns server)
Some remarks:
I imagine AdGuard could do that because it acts "outside" of Safari, doesn't it?
#%#AG_onload!function(){window.location.href
but I means nothing to me :pThank you,
Best regards,
@Chinaski1 commented on Tue Nov 30 2021
Hello there!
As you correctly pointed out, you can use the
$removeparam
rule to remove tracking parameters.We have also implemented a URL Tracking filter that can be used for this purpose.
@imTHAI commented on Tue Nov 30 2021
Hello,
I'm not sure I understand you answer. You agree $removeparam cannot achieve my purpose right ?
@ameshkov commented on Tue Nov 30 2021
Ah, I got it.
Well, we were thinking about some sort of a
$rewrite
parameter, but the problem with it is that it can be rather dangerous. We might consider it for trusted filters, though.@Chinaski1 probably should be moved to the CoreLibs repo.
The text was updated successfully, but these errors were encountered: