-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add regexp support for $domain modifier #1550
Comments
Why limit just to the cosmetic rules? If we do it here, we should extend it to basic rules as well. @sfionov can we include this in v1.10 for instance? |
Yes, assigned to 1.10 |
Another one example |
@AdguardTeam maybe unrelated question but what about redirects? For example links from |
uBo implemented regex, if someone trust something like: /bad-js.$domain=/[a-z-]{18}\.[\w]{2,20}/
/[a-z-]{18}\.[\w]{2,20}/##.bad-class
!
! regex in the dumb version - rather, the webmaster fell how to avoid falling into a safe regex. but fail for uBlockOrigin/uBlock-issues#2234 (comment) In theory, network filtering can be unprotected by The scriptlet is also still possible to run all over the Internet in uBo, but there have been considerations for years whether to secure this with a minimum of "I am an advanced user" activation. Also voe is covered sometimes: uBlockOrigin/uAssets@5a660a9 (Unfortunately, I don't see how to turn these 36 domains into which regex - The site appears to have no fixed pattern (diffrent words, number order)) |
now there is no chance to create single cosmetic rule for hiding the same element on such domains:
example1.com, example2.com, example3.org
it would be nice if $domain modifier supports regular expressions, just like $path does
something like this:
[$domain=/example[0-9]\.(com|org)/]##.ad
The text was updated successfully, but these errors were encountered: